{"id":126374305,"iid":5384,"description":"Version `chains//blocks//` and `chains//blocks//operations` to output `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds in JSON","title":"protocol/plugin: Allow chains//blocks//(operations) to output attestation kind in JSON","time_estimate":0,"total_time_spent":0,"human_time_estimate":null,"human_total_time_spent":null,"state":"closed","milestone_id":3033303,"updated_by_id":4535828,"created_at":"2023-04-07T13:05:54Z","updated_at":"2023-06-29T13:12:43Z","milestone":{"id":3033303,"iid":199,"project_id":3836952,"title":"Renaming (pre)endorsements","description":"# Motivation The term “endorsement” incorrectly conveys the idea that validators (i.e. bakers) approve of the transactions included in a block proposal by the block producer, even though they are merely attesting that a valid block has been produced. The goal of this milestone is to rename the `(pre)endorsement` into `(pre)attestation` in the **Tezos** protocol codebase, as well as in the **Octez** codebase. # Work Breakdown The work that needs to be done for this milestone can be divided into two parts: * UX changes that will impact users * Code base changes that will impact developers ## UX changes (ETA - End of ~~June~~ July) ### Nairobi changes * [x] Renaming `endorsing_rights` (https://gitlab.com/tezos/tezos/-/issues/5149, https://gitlab.com/tezos/tezos/-/merge_requests/8096) ### Operation encoding allows `attestation` (ETA - ~~Start~~ End of May) * [x] (Days) Update the `operation_encoding` to accept `attestation` (and `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence`) as an alias for `endorsement` kind (https://gitlab.com/tezos/tezos/-/issues/5357, https://gitlab.com/tezos/tezos/-/merge_requests/8254 / https://gitlab.com/tezos/tezos/-/merge_requests/8563) * [x] (Days) Update the `operation_receipt_encoding` to be able to output both `attestation` (and `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence`) and `endorsement` kind in JSON (https://gitlab.com/tezos/tezos/-/issues/5358, https://gitlab.com/tezos/tezos/-/merge_requests/8531) * [x] (Hours) Export legacy `operation_encoding`, `operation_receipt_encoding` and `operation_data_and_receipt_encoding` in the env and use it in the shell. (https://gitlab.com/tezos/tezos/-/merge_requests/8620) * [x] (Hours) Update the `balance_updates_encoding` to be able to output both `attestation rewards` and `endorsing rewards` kind in JSON and export legacy `block_header_metadata_encoding_with_legacy_attestation_name` in the env and use it in the shell (https://gitlab.com/tezos/tezos/-/merge_requests/9251) ### POST - input support for `attestation` kinds (ETA - Mid of June) * [x] Protocol/Plugin * [x] (Days) Allow `forge/operations` to accept operation in JSON with `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds by versioning it (https://gitlab.com/tezos/tezos/-/issues/5380, https://gitlab.com/tezos/tezos/-/merge_requests/8746) * [x] (Hours) Allow `run_operation` and `simulate_operation` to accept operation in JSON with `double_attestation_evidence` and `double_preattestation_evidence` kind by versioning it (https://gitlab.com/tezos/tezos/-/issues/5382, https://gitlab.com/tezos/tezos/-/merge_requests/8768) * [x] (Hours) Allow `run_operation` and `simulate_operation` to output operation with both double_attestation_evidence and double_preattestation_evidence kinds by versioning it (https://gitlab.com/tezos/tezos/-/issues/5763, https://gitlab.com/tezos/tezos/-/merge_requests/8949) * [x] (Days) Allow `parse/operations` to output operation in JSON with `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds by versioning it (https://gitlab.com/tezos/tezos/-/issues/5381, https://gitlab.com/tezos/tezos/-/merge_requests/8840) * [x] Shell * [x] (Days) Allow `preapply/operations` to allow operation in JSON with `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds by versioning it (https://gitlab.com/tezos/tezos/-/issues/5383, https://gitlab.com/tezos/tezos/-/merge_requests/8891) ### GET - output support for `attestation` kinds (ETA - End of June) * [x] Shell * [x] (Days) Allow `chains//blocks//` and `chains//blocks//operations` to output `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds in JSON (https://gitlab.com/tezos/tezos/-/issues/5384, https://gitlab.com/tezos/tezos/-/merge_requests/9008) * [x] (Hours) Allow `chains//blocks//` and `chains//blocks//metadata` to output `attestation rewards` and `lost attestation rewards` kinds in JSON (https://gitlab.com/tezos/tezos/-/merge_requests/9253) * [x] Mempool * [x] (Days) Allow `monitor_operations` to output `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds in JSON (https://gitlab.com/tezos/tezos/-/issues/5385, https://gitlab.com/tezos/tezos/-/merge_requests/8980) * [x] (Hours) Allow `pending_operations` to output `attestation`, `preattestation`, `double_attestation_evidence` and `double_preattestation_evidence` kinds in JSON (https://gitlab.com/tezos/tezos/-/issues/5386, https://gitlab.com/tezos/tezos/-/merge_requests/8960) ### Events and errors uses `attestation` (ETA - Mid of July) * [x] Protocol * [x] Lib_protocol * [x] (Hours) Update event and error messages to output `attestation` instead of `endorsement` and update tests accordingly (https://gitlab.com/tezos/tezos/-/issues/5388, https://gitlab.com/tezos/tezos/-/merge_requests/9192) * [x] Lib_delegate * [x] Baker * [x] (Hours) Update event and error messages to output `attestation` instead of `endorsement` and update tests accordingly (https://gitlab.com/tezos/tezos/-/issues/5389, https://gitlab.com/tezos/tezos/-/merge_requests/9195) * [x] Accuser * [x] (Hours) Update event and error messages to output `attestation` instead of `endorsement` and update tests accordingly (https://gitlab.com/tezos/tezos/-/issues/5390, https://gitlab.com/tezos/tezos/-/merge_requests/9196) * [x] Lib_client * [x] (Hours) Update event and error messages to output `attestation` instead of `endorsement` and update tests accordingly (https://gitlab.com/tezos/tezos/-/issues/5392, https://gitlab.com/tezos/tezos/-/merge_requests/9232) ### Logs and Documentation update to use `attestation` (ETA - End of July) It is possible that this part will be inlined in the previous works * [x] RPCs * [x] Document version rpc argument (https://gitlab.com/tezos/tezos/-/merge_requests/9182) * [x] Docs * [x] Protocol `alpha` (https://gitlab.com/tezos/tezos/-/issues/5387, https://gitlab.com/tezos/tezos/-/merge_requests/9429) * [x] API (consequences of API versioning and multiple encoding), will be done in the v18 (https://gitlab.com/tezos/tezos/-/merge_requests/9731). ## Code base changes (ETA - end of July) These changes will mainly be, renaming types, variables, and functions that impact a huge part of the code ### No mention of endorsements in the **Tezos** protocol code (ETA - end of July) * [x] Operation_repr (Change in this file will have impact on many other such as validate, lib_delegate, tests, etc) * [x] Consensus kind (https://gitlab.com/tezos/tezos/-/issues/5393, https://gitlab.com/tezos/tezos/-/merge_requests/9355) * [x] Renaming of `operations_repr` contents type and overall `lib_protocol` occurrences of: (https://gitlab.com/tezos/tezos/-/issues/5394) * [x] `Preendorsement` (https://gitlab.com/tezos/tezos/-/merge_requests/9362) * [x] `Double_preendorsement_evidence` (https://gitlab.com/tezos/tezos/-/merge_requests/9364) * [x] `Endorsement` (https://gitlab.com/tezos/tezos/-/merge_requests/9424) * [x] `Double_endorsement_evidence` (https://gitlab.com/tezos/tezos/-/merge_requests/9425) * [x] Watermarks (https://gitlab.com/tezos/tezos/-/issues/5395, https://gitlab.com/tezos/tezos/-/merge_requests/9424 and https://gitlab.com/tezos/tezos/-/merge_requests/9362) * [x] Storage and Internal encodings (https://gitlab.com/tezos/tezos/-/merge_requests/9486) * [x] Functions (https://gitlab.com/tezos/tezos/-/merge_requests/9440) ### No mention of endorsements in **Octez** code (ETA - End of July) * [x] codebase * [x] Lib_delegate * [x] Commands (https://gitlab.com/tezos/tezos/-/merge_requests/9494) * [x] Code base (https://gitlab.com/tezos/tezos/-/merge_requests/9497) * [x] Lig_plugin (https://gitlab.com/tezos/tezos/-/merge_requests/9500) * [x] Lib_client (https://gitlab.com/tezos/tezos/-/merge_requests/9501) * ~~Lib_crypto + env (https://gitlab.com/tezos/tezos/-/merge_requests/9568)~~ Remaining `endorsement` are only for legacy compatibility. * [x] Tests * [x] Lib_protocol * [x] Helpers (https://gitlab.com/tezos/tezos/-/merge_requests/9559) * [x] Tests (https://gitlab.com/tezos/tezos/-/merge_requests/9562) * [x] Lib_delegate (https://gitlab.com/tezos/tezos/-/merge_requests/9557) * [x] Tezt * [x] Tests (https://gitlab.com/tezos/tezos/-/merge_requests/9580)","state":"closed","created_at":"2023-03-17T08:06:27.802Z","updated_at":"2023-08-17T14:31:57.436Z","due_date":"2023-07-31","start_date":"2023-03-20","expired":true,"web_url":"https://gitlab.com/tezos/tezos/-/milestones/199"},"labels":[{"id":22355727,"title":"proto::plugins","color":"#0000ff","description":"Protocol Plugins","text_color":"#FFFFFF","created_at":"2021-10-29T14:22:56.301Z","updated_at":"2021-10-29T14:28:05.786Z","group_id":null,"project_id":3836952,"template":false},{"id":2470629,"title":"rpc ☎","color":"#f8f8f8","description":"","text_color":"#1F1E24","created_at":"2017-08-10T15:21:38.681Z","updated_at":"2017-08-17T15:58:07.997Z","group_id":null,"project_id":3836952,"template":false}],"lock_version":1,"author_id":1550952,"confidential":false,"discussion_locked":null,"assignees":[{"id":1550952,"username":"ACoquereau","public_email":"","name":"Albin Coquereau","state":"active","locked":false,"avatar_url":"https://gitlab.com/uploads/-/system/user/avatar/1550952/avatar.png","web_url":"https://gitlab.com/ACoquereau"}],"due_date":"2023-06-02","project_id":3836952,"moved_to_id":null,"duplicated_to_id":null,"web_url":"/tezos/tezos/-/issues/5384","current_user":{"can_create_note":false,"can_create_confidential_note":false,"can_update":false,"can_set_issue_metadata":false,"can_award_emoji":false},"create_note_path":"/tezos/tezos/notes?target_id=126374305&target_type=issue","preview_note_path":"/tezos/tezos/-/preview_markdown?target_id=5384&target_type=Issue","is_project_archived":false,"issue_email_participants":[],"type":"ISSUE","weight":null,"blocked":false,"blocked_by_issues":[]}

protocol/plugin: Allow chains/<chain>/blocks/<block>/(operations) to output attestation kind in JSON