diff --git a/README.md b/README.md index e5631f909f1a89ad300b12d0acae2559aace4453..4d9ec4bf6893ae5d72ee9bb60679ee369ff31959 100644 --- a/README.md +++ b/README.md @@ -60,7 +60,9 @@ import ( Anyone can contribute! -Please be aware of the following however. +### Architectural guidelines + +Please be aware of the following architectural guidelines. ### Public APIs in LabKit should be stable @@ -94,3 +96,22 @@ This book is recommended reading. * Separate general-purpose and special-purpose code * Design it twice * Comments should describe things that are not obvious from the code + +### Review Process + +Please assign your MR to a reviewer for a first review, followed by a maintainer review. + +Currently, the reviewers are: + +1. [@igorwwwwwwwwwwwwwwwwwwww](https://gitlab.com/igorwwwwwwwwwwwwwwwwwwww) +1. [@jdrpereira](https://gitlab.com/jdrpereira) +1. [@8bitlife](https://gitlab.com/8bitlife) + +The maintainers are: + +1. [@andrewn](https://gitlab.com/andrewn) +1. [@hphilipps](https://gitlab.com/hphilipps) +1. [@steveazz](https://gitlab.com/steveazz) +1. [@zj-gitlab](https://gitlab.com/zj-gitlab) + +While not strictly neccessary, it is preferred for the author of changes to also send downstream MRs to Gitaly, Workhorse, GitLab-Pages and KAS to update those clients to the latest LabKit version.