From 84b34eeb4fa66b9358500abebb19f4ebd14f6eee Mon Sep 17 00:00:00 2001 From: e_forbes Date: Tue, 4 Nov 2025 11:11:45 +0000 Subject: [PATCH 1/2] chore: adds the danger component from common-ci-tasks to enable reviewer roulette --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 79882df4..d934793d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -33,6 +33,8 @@ include: ref: v2.94 # renovate:managed file: templates/golang.yml + - component: $CI_SERVER_FQDN/gitlab-com/gl-infra/common-ci-tasks/danger@v2.78 + variables: REPO_NAME: gitlab.com/gitlab-org/labkit SAST_EXCLUDED_ANALYZERS: "eslint,gosec,nodejs-scan" -- GitLab From 8da6355c7d01bee918474656de08b5e9d0b95c4c Mon Sep 17 00:00:00 2001 From: e_forbes Date: Wed, 5 Nov 2025 16:44:40 +0000 Subject: [PATCH 2/2] Uses the danger-review component as opposed to the bundled common-ci-tasks --- .gitlab-ci.yml | 6 +++++- Dangerfile | 11 +++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 Dangerfile diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d934793d..11a3295c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -13,6 +13,7 @@ workflow: # Requires stages validate, release and renovate_bot stages: + - init - validate - release - renovate_bot @@ -33,7 +34,10 @@ include: ref: v2.94 # renovate:managed file: templates/golang.yml - - component: $CI_SERVER_FQDN/gitlab-com/gl-infra/common-ci-tasks/danger@v2.78 + - component: "gitlab.com/gitlab-org/components/danger-review/danger-review@~latest" + inputs: + job_stage: init + variables: REPO_NAME: gitlab.com/gitlab-org/labkit diff --git a/Dangerfile b/Dangerfile new file mode 100644 index 00000000..20434b48 --- /dev/null +++ b/Dangerfile @@ -0,0 +1,11 @@ +# frozen_string_literal: true + +require 'gitlab-dangerfiles' + +Gitlab::Dangerfiles.for_project(self) do |gitlab_dangerfiles| + gitlab_dangerfiles.import_plugins + + # we don't want commit messages and changelog as we use sematic commit messages + # for those + gitlab_dangerfiles.import_dangerfiles(except: %w[changelog commit_messages]) +end -- GitLab