From f01e55fa3396909b8cdef6b9a99fbcf94b06f6c4 Mon Sep 17 00:00:00 2001 From: Luke Kysow Date: Thu, 26 Apr 2018 19:57:56 +0000 Subject: [PATCH] Change approvals_missing to approvals_left. GitLab doesn't actually return the approvals_missing field it's called approvals_left. See this comment from a year ago as well: https://gitlab.com/gitlab-org/gitlab-ee/issues/1118#note_17875041 --- doc/api/merge_request_approvals.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/api/merge_request_approvals.md b/doc/api/merge_request_approvals.md index eb9c533ec82d4b..4fa88637ae89bf 100644 --- a/doc/api/merge_request_approvals.md +++ b/doc/api/merge_request_approvals.md @@ -211,7 +211,7 @@ GET /projects/:id/merge_requests/:merge_request_iid/approvals "updated_at": "2016-06-08T21:20:42.470Z", "merge_status": "cannot_be_merged", "approvals_required": 2, - "approvals_missing": 1, + "approvals_left": 1, "approved_by": [ { "user": { @@ -261,7 +261,7 @@ POST /projects/:id/merge_requests/:merge_request_iid/approvals "updated_at": "2016-06-08T21:20:42.470Z", "merge_status": "cannot_be_merged", "approvals_required": 2, - "approvals_missing": 2, + "approvals_left": 2, "approved_by": [], "approvers": [], "approver_groups": [] @@ -302,7 +302,7 @@ PUT /projects/:id/merge_requests/:merge_request_iid/approvers "updated_at": "2016-06-08T21:20:42.470Z", "merge_status": "cannot_be_merged", "approvals_required": 2, - "approvals_missing": 2, + "approvals_left": 2, "approved_by": [], "approvers": [ { -- GitLab