From 5ef791f8e10f542752b25e5485161cb6cb6a705d Mon Sep 17 00:00:00 2001
From: Himanshu Kapoor <hkapoor@gitlab.com>
Date: Tue, 7 Jan 2025 18:47:09 +0100
Subject: [PATCH] Change footer text for GLQL content

Change text to read "View powered by GLQL"
---
 .../javascripts/glql/components/presenters/list.vue      | 9 ++++++---
 .../javascripts/glql/components/presenters/table.vue     | 9 ++++++---
 locale/gitlab.pot                                        | 6 +++---
 spec/frontend/glql/components/presenters/list_spec.js    | 6 ++++++
 spec/frontend/glql/components/presenters/table_spec.js   | 6 ++++++
 5 files changed, 27 insertions(+), 9 deletions(-)

diff --git a/app/assets/javascripts/glql/components/presenters/list.vue b/app/assets/javascripts/glql/components/presenters/list.vue
index 68686164441c5d..9112c466d48b9a 100644
--- a/app/assets/javascripts/glql/components/presenters/list.vue
+++ b/app/assets/javascripts/glql/components/presenters/list.vue
@@ -38,11 +38,11 @@ export default {
       return this.config.fields;
     },
     docsPath() {
-      return helpPagePath('user/glql/index');
+      return `${helpPagePath('user/glql/index')}#glql-views`;
     },
   },
   i18n: {
-    generatedMessage: __('Generated by %{linkStart}GLQL%{linkEnd}'),
+    generatedMessage: __('%{linkStart}View%{linkEnd} powered by GLQL'),
   },
 };
 </script>
@@ -64,7 +64,10 @@ export default {
         {{ __('No data found for this query') }}
       </div>
     </component>
-    <div class="gl-mt-3 gl-flex gl-items-center gl-gap-1 gl-text-sm gl-text-subtle">
+    <div
+      class="gl-mt-3 gl-flex gl-items-center gl-gap-1 gl-text-sm gl-text-subtle"
+      data-testid="footer"
+    >
       <gl-icon class="gl-mb-1 gl-mr-1" :size="12" name="tanuki" />
       <gl-sprintf :message="$options.i18n.generatedMessage">
         <template #link="{ content }">
diff --git a/app/assets/javascripts/glql/components/presenters/table.vue b/app/assets/javascripts/glql/components/presenters/table.vue
index 3bbf3ac2a86da7..49d9e49ed0c42d 100644
--- a/app/assets/javascripts/glql/components/presenters/table.vue
+++ b/app/assets/javascripts/glql/components/presenters/table.vue
@@ -39,7 +39,7 @@ export default {
   },
   computed: {
     docsPath() {
-      return helpPagePath('user/glql/index');
+      return `${helpPagePath('user/glql/index')}#glql-views`;
     },
   },
   async mounted() {
@@ -48,7 +48,7 @@ export default {
     this.table = this.$refs.table;
   },
   i18n: {
-    generatedMessage: __('Generated by %{linkStart}GLQL%{linkEnd}'),
+    generatedMessage: __('%{linkStart}View%{linkEnd} powered by GLQL'),
   },
 };
 </script>
@@ -89,7 +89,10 @@ export default {
         </tr>
       </tbody>
     </table>
-    <div class="gl-mt-3 gl-flex gl-items-center gl-gap-1 gl-text-sm gl-text-subtle">
+    <div
+      class="gl-mt-3 gl-flex gl-items-center gl-gap-1 gl-text-sm gl-text-subtle"
+      data-testid="footer"
+    >
       <gl-icon class="gl-mb-1 gl-mr-1" :size="12" name="tanuki" />
       <gl-sprintf :message="$options.i18n.generatedMessage">
         <template #link="{ content }">
diff --git a/locale/gitlab.pot b/locale/gitlab.pot
index 70d183d9c67048..c7cd3daea53417 100644
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -1053,6 +1053,9 @@ msgstr ""
 msgid "%{linkStart}Advanced search%{linkEnd} is enabled."
 msgstr ""
 
+msgid "%{linkStart}View%{linkEnd} powered by GLQL"
+msgstr ""
+
 msgid "%{link_start}Communication Preference Center%{link_end}."
 msgstr ""
 
@@ -24637,9 +24640,6 @@ msgstr ""
 msgid "Generate site and private keys at"
 msgstr ""
 
-msgid "Generated by %{linkStart}GLQL%{linkEnd}"
-msgstr ""
-
 msgid "Generated files are collapsed by default. To change this behavior, edit the %{tagStart}.gitattributes%{tagEnd} file. %{linkStart}Learn more.%{linkEnd}"
 msgstr ""
 
diff --git a/spec/frontend/glql/components/presenters/list_spec.js b/spec/frontend/glql/components/presenters/list_spec.js
index c64cd2bcf8018c..f5b3a273d9576f 100644
--- a/spec/frontend/glql/components/presenters/list_spec.js
+++ b/spec/frontend/glql/components/presenters/list_spec.js
@@ -62,6 +62,12 @@ describe('ListPresenter', () => {
     expect(wrapper.find('ul')).toBeDefined();
   });
 
+  it('renders a footer text', () => {
+    createWrapper({ data: MOCK_ISSUES, config: { fields: MOCK_FIELDS } }, mountExtended);
+
+    expect(wrapper.findByTestId('footer').text()).toEqual('View powered by GLQL');
+  });
+
   it('renders a ol if passed as a prop', () => {
     createWrapper({ data: MOCK_ISSUES, config: { fields: MOCK_FIELDS }, listType: 'ol' });
 
diff --git a/spec/frontend/glql/components/presenters/table_spec.js b/spec/frontend/glql/components/presenters/table_spec.js
index d5986765b6ddca..f1fb23e10b0187 100644
--- a/spec/frontend/glql/components/presenters/table_spec.js
+++ b/spec/frontend/glql/components/presenters/table_spec.js
@@ -33,6 +33,12 @@ describe('TablePresenter', () => {
     expect(headerCells).toEqual(['Title', 'Author', 'State', 'Description']);
   });
 
+  it('renders a footer text', () => {
+    createWrapper({ data: MOCK_ISSUES, config: { fields: MOCK_FIELDS } }, mountExtended);
+
+    expect(wrapper.findByTestId('footer').text()).toEqual('View powered by GLQL');
+  });
+
   it('renders a row of items presented by appropriate presenters', async () => {
     await createWrapper({ data: MOCK_ISSUES, config: { fields: MOCK_FIELDS } }, mountExtended);
 
-- 
GitLab