BE [Group Owner bypass ] Implement "enterprise bypass of placeholder user confirmation" expiry date
About
This issue is part of the epic &17871. See that epic for more context.
The BE MR !188810 (merged) adds the allow_enterprise_bypass_placeholder_confirmation column to namespace_settings. This issue will implement the expiry date column and logic related to this setting, initially discussed here and discussed further here.
Requirements
- Choosing an expiry date will be required.
- The frontend will provide a date string along with the bypass setting
The options are30 days,60 days,90 days,6 monthsand1 yearoptions.- When expired, the by-pass will no longer apply.
Implementation
- Migrate a new column to
namespace_settingsfor the setting. - As choosing an expiry date is required - add a model validation to
NamespaceSettingto validate that ifallow_enterprise_bypass_placeholder_confirmationis enabled then a date has been chosen - Update backend logic that applies the by-pass skipping #542284 (closed) to factor in the expiry setting. When the by-pass has expired, the by-pass will no longer apply.
-
⚠️ All MRs must be reviewed by AppSec (@ameyadarshan) (see https://gitlab.com/gitlab-com/gl-security/product-security/appsec/appsec-reviews/-/issues/250).
- Started in !189546 (merged). Follow up issue after backend in merged -> #546425 (closed)
We will add a new required select list to the settings that were added in #534329 (closed) for an Expiration dateThe options for the select list are30 days,60 days,90 days,6 monthsand1 yearoptions.
Edited by 🤖 GitLab Bot 🤖