From 490e3a3bdb800e814989f9ee7742bf8e4179b773 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Wed, 20 May 2020 18:20:54 +0200 Subject: [PATCH 1/3] DO NOT MRRGE test issuebot --- .gitlab-ci.yml | 4 ++-- tools/trigger-issuebot | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index db80a574d0c5..7a5137d69704 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -395,8 +395,8 @@ pages: - curl --silent https://gitlab.com/fdroid/gradle-plugins/-/archive/master/gradle-plugins-master.tar.gz | tar -xz --directory=$GRADLE_USER_HOME/fdroid --strip-components=1 - - git ls-remote https://gitlab.com/fdroid/issuebot.git master - - curl --silent https://gitlab.com/fdroid/issuebot/-/archive/master/issuebot-master.tar.gz + - git ls-remote https://gitlab.com/eighthave/issuebot.git master + - curl --silent https://gitlab.com/eighthave/issuebot/-/archive/master/issuebot-master.tar.gz | tar -xz --strip-components=1 - pyvenv --system-site-packages --clear issuebot-env - . issuebot-env/bin/activate diff --git a/tools/trigger-issuebot b/tools/trigger-issuebot index fece404bd048..3cee5d914d23 100755 --- a/tools/trigger-issuebot +++ b/tools/trigger-issuebot @@ -36,7 +36,7 @@ fi curl --silent --request POST \ --form token="$issuebot" \ - --form ref=master \ + --form ref=test-issuebot-2 \ --form "variables[FROM_CI_COMMIT_REF_NAME]=$CI_COMMIT_REF_NAME" \ --form "variables[FROM_CI_COMMIT_REF_SLUG]=$CI_COMMIT_REF_SLUG" \ --form "variables[FROM_CI_COMMIT_SHA]=$CI_COMMIT_SHA" \ -- GitLab From 049add8dd8e76b2ef8872b3613ac80bb756f646e Mon Sep 17 00:00:00 2001 From: Jochen Sprickerhof Date: Thu, 15 Sep 2022 08:47:43 +0200 Subject: [PATCH 2/3] Recover --name-only and properly fix Python 3.5 syntax --- tools/find-changed-builds.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/find-changed-builds.py b/tools/find-changed-builds.py index 776a31d5afe2..5dce7486d967 100755 --- a/tools/find-changed-builds.py +++ b/tools/find-changed-builds.py @@ -14,11 +14,10 @@ target_ref = os.getenv('TARGET_REF') source_ref = os.getenv('SOURCE_REF') for appid in sorted(changed): - metadata_file = 'metadata/' + appid +'.yml' + metadata_file = 'metadata/{appid}.yml'.format(**locals()) diff = subprocess.check_output( ( - 'git diff --no-color --diff-filter=d ' + target_ref + - '...' + source_ref + ' -- ' + metadata_file + 'git diff --no-color --diff-filter=d {target_ref}...{source_ref} -- {metadata_file}' .format(**locals()) ).split(' ') ) @@ -83,8 +82,7 @@ for appid in sorted(changed): signatures_dir = 'metadata/%s/signatures/' % appid diff = subprocess.check_output( ( - 'git diff --no-color --diff-filter=d ' + target_ref + - '...' + source_ref + ' -- ' + signatures_dir + 'git diff --name-only --no-color --diff-filter=d {target_ref}...{source_ref} -- {signatures_dir}'.format(**locals()) ).split(' ') ) for f in diff.split(): -- GitLab From 741f854e18d7b08e505938576ade3e4b8e8f4888 Mon Sep 17 00:00:00 2001 From: Jochen Sprickerhof Date: Thu, 15 Sep 2022 13:04:30 +0200 Subject: [PATCH 3/3] CI: Fail when find-changed-builds fails Closes: 2761 --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7a5137d69704..f7ff9806187e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -337,7 +337,8 @@ fdroid build: - printf "keystore\x3a $keystore\n" >> config.yml - chown vagrant $keystore - - for build in `./tools/find-changed-builds.py`; do + - APPS="$(./tools/find-changed-builds.py)" + - for build in $APPS; do set -x; apt-get install sudo; chown -R vagrant $home_vagrant; -- GitLab