From c4b61ae66b807fdb044f786fe25b563b2b372e09 Mon Sep 17 00:00:00 2001
From: SilentGhost <ghost.adh@runbox.com>
Date: Thu, 24 Oct 2024 12:33:03 +0200
Subject: [PATCH] Filter out inactive apps early

Skip processing of apps with UpdateCheckMode: None or Static. This saves time on
parsing more than 1800 yaml files.
Extract appid directly without a for loop.
---
 .gitlab-ci.yml | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 308b094..80053f7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -63,25 +63,14 @@ checkupdates_runner:
   script:
     # Get app IDs in this batch
     - |
-      metadata_files=(metadata/*.yml)
-      metadata_files_count=${#metadata_files[@]}
-      batch_size=$((metadata_files_count / CI_NODE_TOTAL + 1))
-      metadata_files_batch=("${metadata_files[@]:$(((CI_NODE_INDEX - 1) * batch_size)):$batch_size}")
-
-      declare -a CHECKUPDATES_APPIDS
-      for file in "${metadata_files_batch[@]}"; do
-        filename="${file##*/}"
-        filename_without_extension="${filename%.*}"
-        CHECKUPDATES_APPIDS=("${CHECKUPDATES_APPIDS[@]}" "$filename_without_extension")
-      done
-
-      export CHECKUPDATES_APPIDS
+      appids=($(grep -PL '^UpdateCheckMode: (None|Static)' metadata/*yml | grep -oP '(?<=metadata/).*(?=.yml)'))
+      appids_count=${#appids[@]}
+      batch_size=$((appids_count / CI_NODE_TOTAL + 1))
+      CHECKUPDATES_APPIDS=("${appids[@]:$(((CI_NODE_INDEX - 1) * batch_size)):$batch_size}")
 
     - echo "$job_branch"
-    - echo "$metadata_files_count"
+    - echo "$appids_count"
     - echo "$batch_size"
-    - echo "${metadata_files_batch[@]}"
-    - echo "${#metadata_files_batch[@]}"
     - echo "${CHECKUPDATES_APPIDS[@]}"
     - echo "${#CHECKUPDATES_APPIDS[@]}"
 
-- 
GitLab