From a54d96f81350a5b524dadd0b523d673cd180d1ff Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Thu, 28 Nov 2024 11:36:05 +0530 Subject: [PATCH 1/2] fix: IndexError in Asset Depreciation Ledger when query result is empty --- .../asset_depreciation_ledger/asset_depreciation_ledger.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py b/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py index dbb63cfe00..eb1b98c20c 100644 --- a/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py +++ b/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py @@ -71,6 +71,7 @@ def get_data(filters): assets = [d.against_voucher for d in gl_entries] assets_details = get_assets_details(assets) + print(gl_entries) for d in gl_entries: asset_data = assets_details.get(d.against_voucher) @@ -89,7 +90,9 @@ def get_data(filters): & (DepreciationSchedule.schedule_date == d.posting_date) ) ).run(as_dict=True) - asset_data.accumulated_depreciation_amount = query[0]["accumulated_depreciation_amount"] + asset_data.accumulated_depreciation_amount = ( + query[0]["accumulated_depreciation_amount"] if query else 0 + ) else: asset_data.accumulated_depreciation_amount += d.debit -- GitLab From 3af84b798596ac9f2ad9d7f79022bb07b481a065 Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Thu, 28 Nov 2024 11:41:00 +0530 Subject: [PATCH 2/2] chore: removed print statement --- .../asset_depreciation_ledger/asset_depreciation_ledger.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py b/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py index eb1b98c20c..ef28e6113f 100644 --- a/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py +++ b/erpnext/accounts/report/asset_depreciation_ledger/asset_depreciation_ledger.py @@ -71,7 +71,6 @@ def get_data(filters): assets = [d.against_voucher for d in gl_entries] assets_details = get_assets_details(assets) - print(gl_entries) for d in gl_entries: asset_data = assets_details.get(d.against_voucher) -- GitLab