From ea74f88db09d2c70058650e2098e8a8f65628020 Mon Sep 17 00:00:00 2001
From: Vincent-Carrier <vincentcarrier15@gmail.com>
Date: Fri, 29 Jun 2018 12:07:23 -0400
Subject: [PATCH 1/2] Begin work on light theme

* Create a spinner in the SettingsActivity

* Create a new theme in styles.xml
---
 app/src/main/AndroidManifest.xml              |  2 +-
 .../gitlab/activity/SettingsActivity.kt       | 39 ++++++++++++++---
 app/src/main/res/layout/activity_settings.xml | 42 +++++++++++++++++--
 app/src/main/res/values/strings.xml           |  6 +++
 app/src/main/res/values/styles.xml            | 17 +++++++-
 app/src/main/res/values/themes.xml            |  7 ++++
 6 files changed, 101 insertions(+), 12 deletions(-)
 create mode 100644 app/src/main/res/values/themes.xml

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 89d6d1b3..9f16894a 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -12,7 +12,7 @@
         android:fullBackupContent="false"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
-        android:theme="@style/AppTheme">
+        android:theme="@style/DarkTheme">
 
         <activity
             android:name=".activity.LaunchActivity"
diff --git a/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt b/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
index 6dcdfc85..bccc6123 100644
--- a/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
+++ b/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
@@ -1,12 +1,17 @@
 package com.commit451.gitlab.activity
 
+import android.R.layout
 import android.content.Context
 import android.content.Intent
 import android.os.Build
 import android.os.Bundle
 import android.view.View
+import android.widget.AdapterView
+import android.widget.AdapterView.OnItemSelectedListener
+import android.widget.ArrayAdapter
 import butterknife.ButterKnife
 import com.commit451.gitlab.R
+import com.commit451.gitlab.R.array
 import com.commit451.gitlab.data.Prefs
 import kotlinx.android.synthetic.main.activity_settings.*
 
@@ -17,10 +22,7 @@ class SettingsActivity : BaseActivity() {
 
     companion object {
 
-        fun newIntent(context: Context): Intent {
-            val intent = Intent(context, SettingsActivity::class.java)
-            return intent
-        }
+        fun newIntent(context: Context) = Intent(context, SettingsActivity::class.java)
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {
@@ -40,9 +42,36 @@ class SettingsActivity : BaseActivity() {
             Prefs.isRequiredDeviceAuth = b
         }
         rootRequireDeviceAuth.setOnClickListener { switchRequireAuth.toggle() }
+
+        bindThemeSpinner()
+    }
+
+    private fun bindThemeSpinner() {
+        themeSpinner.adapter = ArrayAdapter.createFromResource(
+            this,
+            array.themes,
+            layout.simple_spinner_item
+        )
+
+        themeSpinner.onItemSelectedListener = object : OnItemSelectedListener {
+            override fun onNothingSelected(parent: AdapterView<*>?) {
+            }
+
+            override fun onItemSelected(
+                parent: AdapterView<*>?,
+                view: View?,
+                position: Int,
+                id: Long
+            ) {
+                when(parent?.getItemAtPosition(position)) {
+                    getString(R.string.dark_theme) -> baseContext.setTheme(0)
+                    getString(R.string.light_theme) -> baseContext.setTheme(0)
+                }
+            }
+        }
     }
 
-    fun bindPrefs() {
+    private fun bindPrefs() {
         switchRequireAuth.isChecked = Prefs.isRequiredDeviceAuth
     }
 }
diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml
index f4b15d2d..c56ac8d6 100644
--- a/app/src/main/res/layout/activity_settings.xml
+++ b/app/src/main/res/layout/activity_settings.xml
@@ -31,7 +31,7 @@
             <LinearLayout
                 android:id="@+id/rootRequireDeviceAuth"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content"
+                android:layout_height="match_parent"
                 android:background="?attr/selectableItemBackground"
                 android:orientation="horizontal"
                 android:paddingBottom="@dimen/activity_vertical_margin"
@@ -50,14 +50,14 @@
                         style="?android:attr/textAppearanceMedium"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
-                        android:text="@string/setting_require_device_auth" />
+                        android:text="@string/setting_require_device_auth"/>
 
                     <TextView
                         style="?android:attr/textAppearance"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:text="@string/setting_require_device_auth_description"
-                        android:textColor="@color/white_60" />
+                        android:textColor="@color/white_60"/>
                 </LinearLayout>
 
 
@@ -66,8 +66,42 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:layout_marginLeft="8dp" />
+                    android:layout_marginLeft="8dp"/>
+
+            </LinearLayout>
 
+            <LinearLayout
+                android:id="@+id/themeTextView"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:background="?attr/selectableItemBackground"
+                android:orientation="horizontal"
+                android:paddingBottom="@dimen/activity_vertical_margin"
+                android:paddingLeft="@dimen/activity_horizontal_margin"
+                android:paddingRight="@dimen/activity_horizontal_margin"
+                android:paddingTop="@dimen/activity_vertical_margin">
+
+                <LinearLayout
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    android:layout_weight="1"
+                    android:gravity="center_vertical"
+                    android:orientation="vertical">
+
+                    <TextView
+                        style="?android:attr/textAppearanceMedium"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:text="@string/setting_theme_title"/>
+
+                </LinearLayout>
+
+                <Spinner
+                    android:id="@+id/themeSpinner"
+                    android:layout_width="0dp"
+                    android:layout_height="42dp"
+                    android:layout_weight="1"
+                    tools:listitem="Dark"/>
             </LinearLayout>
 
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 4014f2b3..a7d04ac3 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -530,4 +530,10 @@
 
     <string name="welcome">Welcome to LabCoat</string>
     <string name="welcome_message">We support GitLab.com, as well as any GitLab server running GitLab version 9.0 or later</string>
+    <string name="setting_theme_title">Theme</string>
+
+    <!-- Themes -->
+    <string name="light_theme">Light</string>
+    <string name="dark_theme">Dark</string>
+
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index dceedd08..9030611c 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -2,7 +2,7 @@
 <resources xmlns:tools="http://schemas.android.com/tools">
 
     <!-- Dark theme (default) -->
-    <style name="AppTheme" parent="Theme.AppCompat.NoActionBar">
+    <style name="DarkTheme" parent="Theme.AppCompat.NoActionBar">
         <item name="colorPrimary">@color/main_blue</item>
         <item name="colorAccent">@color/yellow</item>
         <item name="colorPrimaryDark">@color/main_blue_darker</item>
@@ -14,7 +14,20 @@
         <item name="alertDialogTheme">@style/AppDialogTheme</item>
     </style>
 
-    <style name="Activity" parent="AppTheme" />
+    <!-- Light theme -->
+    <style name="LightTheme" parent="Theme.AppCompat.NoActionBar">
+        <item name="colorPrimary">@color/white</item>
+        <item name="colorAccent">@color/yellow</item>
+        <item name="colorPrimaryDark">@color/white_60</item>
+        <item name="android:navigationBarColor" tools:targetApi="lollipop">@color/white_60
+        </item>
+        <item name="android:windowContentTransitions" tools:ignore="NewApi">true</item>
+        <item name="android:windowBackground">@color/white</item>
+        <item name="dialogTheme">@style/AppDialogTheme</item>
+        <item name="alertDialogTheme">@style/AppDialogTheme</item>
+    </style>
+
+    <style name="Activity" parent="DarkTheme" />
 
     <style name="Activity.Login">
         <item name="android:windowBackground">?attr/colorPrimary</item>
diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml
new file mode 100644
index 00000000..8ae1ea30
--- /dev/null
+++ b/app/src/main/res/values/themes.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string-array name="themes">
+        <item>@string/dark_theme</item>
+        <item>@string/light_theme</item>
+    </string-array>
+</resources>
\ No newline at end of file
-- 
GitLab


From 6315fa4fc51f73fbfb8ca284e18f7303ec2b28f8 Mon Sep 17 00:00:00 2001
From: Vincent-Carrier <vincentcarrier15@gmail.com>
Date: Thu, 12 Jul 2018 09:51:41 -0400
Subject: [PATCH 2/2] Persist theme in settings and apply it to BaseActivity

---
 .../commit451/gitlab/activity/BaseActivity.kt |  8 ++++
 .../gitlab/activity/SettingsActivity.kt       | 43 +++++++------------
 .../java/com/commit451/gitlab/data/Prefs.kt   | 15 ++++---
 app/src/main/res/layout/activity_settings.xml | 25 +++++------
 app/src/main/res/values/strings.xml           |  1 +
 app/src/main/res/values/styles.xml            |  4 +-
 6 files changed, 50 insertions(+), 46 deletions(-)

diff --git a/app/src/main/java/com/commit451/gitlab/activity/BaseActivity.kt b/app/src/main/java/com/commit451/gitlab/activity/BaseActivity.kt
index 54a27c78..eaea52a1 100644
--- a/app/src/main/java/com/commit451/gitlab/activity/BaseActivity.kt
+++ b/app/src/main/java/com/commit451/gitlab/activity/BaseActivity.kt
@@ -1,8 +1,11 @@
 package com.commit451.gitlab.activity
 
+import android.os.Bundle
+import android.os.PersistableBundle
 import android.support.v7.app.AppCompatActivity
 import com.commit451.gitlab.App
 import com.commit451.gitlab.api.GitLab
+import com.commit451.gitlab.data.Prefs
 import com.commit451.gitlab.model.Account
 import com.novoda.simplechromecustomtabs.SimpleChromeCustomTabs
 import com.uber.autodispose.android.lifecycle.AndroidLifecycleScopeProvider
@@ -24,6 +27,11 @@ abstract class BaseActivity : AppCompatActivity() {
         return false
     }
 
+    override fun onCreate(savedInstanceState: Bundle?, persistentState: PersistableBundle?) {
+        super.onCreate(savedInstanceState, persistentState)
+        setTheme(Prefs.theme)
+    }
+
     override fun onResume() {
         super.onResume()
         if (hasBrowsableLinks()) {
diff --git a/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt b/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
index bccc6123..55c8bfc3 100644
--- a/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
+++ b/app/src/main/java/com/commit451/gitlab/activity/SettingsActivity.kt
@@ -1,17 +1,13 @@
 package com.commit451.gitlab.activity
 
-import android.R.layout
 import android.content.Context
 import android.content.Intent
 import android.os.Build
 import android.os.Bundle
+import android.support.v7.app.AlertDialog
 import android.view.View
-import android.widget.AdapterView
-import android.widget.AdapterView.OnItemSelectedListener
-import android.widget.ArrayAdapter
 import butterknife.ButterKnife
 import com.commit451.gitlab.R
-import com.commit451.gitlab.R.array
 import com.commit451.gitlab.data.Prefs
 import kotlinx.android.synthetic.main.activity_settings.*
 
@@ -43,32 +39,25 @@ class SettingsActivity : BaseActivity() {
         }
         rootRequireDeviceAuth.setOnClickListener { switchRequireAuth.toggle() }
 
-        bindThemeSpinner()
+        themeSettingLayout.setOnClickListener { showThemePickerDialog() }
     }
 
-    private fun bindThemeSpinner() {
-        themeSpinner.adapter = ArrayAdapter.createFromResource(
-            this,
-            array.themes,
-            layout.simple_spinner_item
-        )
-
-        themeSpinner.onItemSelectedListener = object : OnItemSelectedListener {
-            override fun onNothingSelected(parent: AdapterView<*>?) {
-            }
-
-            override fun onItemSelected(
-                parent: AdapterView<*>?,
-                view: View?,
-                position: Int,
-                id: Long
-            ) {
-                when(parent?.getItemAtPosition(position)) {
-                    getString(R.string.dark_theme) -> baseContext.setTheme(0)
-                    getString(R.string.light_theme) -> baseContext.setTheme(0)
+    private fun showThemePickerDialog() {
+        AlertDialog.Builder(this)
+            .setTitle(R.string.pick_a_theme)
+            .setSingleChoiceItems(R.array.themes, 0) { _, position->
+                val newTheme = when (resources.getStringArray(R.array.themes)[position]) {
+                    resources.getString(R.string.dark_theme) -> R.style.DarkTheme
+                    resources.getString(R.string.light_theme) -> R.style.LightTheme
+                    else -> throw IllegalArgumentException("This theme does not exist")
                 }
+
+                Prefs.theme = newTheme
+                finish()
+                startActivity(Intent(this, this::class.java))
             }
-        }
+            .create()
+            .show()
     }
 
     private fun bindPrefs() {
diff --git a/app/src/main/java/com/commit451/gitlab/data/Prefs.kt b/app/src/main/java/com/commit451/gitlab/data/Prefs.kt
index 686fc415..55d6de72 100644
--- a/app/src/main/java/com/commit451/gitlab/data/Prefs.kt
+++ b/app/src/main/java/com/commit451/gitlab/data/Prefs.kt
@@ -5,15 +5,13 @@ import android.content.Context
 import android.content.SharedPreferences
 import android.preference.PreferenceManager
 import android.support.annotation.IntDef
+import android.support.annotation.StyleRes
+import com.commit451.gitlab.R
 import com.commit451.gitlab.api.MoshiProvider
 import com.commit451.gitlab.model.Account
-import java.io.IOException
-import java.util.*
-import com.squareup.moshi.Moshi
-import com.squareup.moshi.JsonAdapter
-import com.squareup.moshi.Types.newParameterizedType
 import com.squareup.moshi.Types
 import timber.log.Timber
+import java.io.IOException
 
 
 /**
@@ -24,6 +22,7 @@ object Prefs {
     private const val KEY_ACCOUNTS = "accounts"
     private const val KEY_STARTING_VIEW = "starting_view"
     private const val KEY_REQUIRE_DEVICE_AUTH = "require_device_auth"
+    private const val KEY_THEME_ID = "theme_id"
 
     const val STARTING_VIEW_PROJECTS = 0
     const val STARTING_VIEW_GROUPS = 1
@@ -106,4 +105,10 @@ object Prefs {
         set(value) = prefs.edit()
                 .putBoolean(KEY_REQUIRE_DEVICE_AUTH, value)
                 .apply()
+
+    var theme: Int
+        @StyleRes get() = prefs.getInt(KEY_THEME_ID, R.style.DarkTheme)
+        set(@StyleRes value) = prefs.edit()
+            .putInt(KEY_THEME_ID, value)
+            .apply()
 }
diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml
index c56ac8d6..57459466 100644
--- a/app/src/main/res/layout/activity_settings.xml
+++ b/app/src/main/res/layout/activity_settings.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools"
-    android:layout_width="match_parent"
-    android:layout_height="match_parent">
+                                                 xmlns:app="http://schemas.android.com/apk/res-auto"
+                                                 xmlns:tools="http://schemas.android.com/tools"
+                                                 android:layout_width="match_parent"
+                                                 android:layout_height="match_parent">
 
     <android.support.design.widget.AppBarLayout
         android:id="@+id/appbar"
@@ -14,7 +14,7 @@
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            android:background="?attr/colorPrimary" />
+            android:background="?attr/colorPrimary"/>
 
     </android.support.design.widget.AppBarLayout>
 
@@ -71,7 +71,7 @@
             </LinearLayout>
 
             <LinearLayout
-                android:id="@+id/themeTextView"
+                android:id="@+id/themeSettingLayout"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:background="?attr/selectableItemBackground"
@@ -94,14 +94,15 @@
                         android:layout_height="wrap_content"
                         android:text="@string/setting_theme_title"/>
 
+                    <TextView
+                        style="?android:attr/textAppearance"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:textColor="@color/white_60"
+                        tools:text="Dark"/>
+
                 </LinearLayout>
 
-                <Spinner
-                    android:id="@+id/themeSpinner"
-                    android:layout_width="0dp"
-                    android:layout_height="42dp"
-                    android:layout_weight="1"
-                    tools:listitem="Dark"/>
             </LinearLayout>
 
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index a7d04ac3..5739ceef 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -535,5 +535,6 @@
     <!-- Themes -->
     <string name="light_theme">Light</string>
     <string name="dark_theme">Dark</string>
+    <string name="pick_a_theme">Choose a theme</string>
 
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 9030611c..74931e88 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -19,8 +19,8 @@
         <item name="colorPrimary">@color/white</item>
         <item name="colorAccent">@color/yellow</item>
         <item name="colorPrimaryDark">@color/white_60</item>
-        <item name="android:navigationBarColor" tools:targetApi="lollipop">@color/white_60
-        </item>
+        <item name="android:textColor">@color/black</item>
+        <item name="android:navigationBarColor" tools:targetApi="lollipop">@color/white_60</item>
         <item name="android:windowContentTransitions" tools:ignore="NewApi">true</item>
         <item name="android:windowBackground">@color/white</item>
         <item name="dialogTheme">@style/AppDialogTheme</item>
-- 
GitLab