This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Inconsistent treatment of keywords in zz.pest #66
Description
I think that for clarity keywords should always have key_* rules and should be in the keyword rule. In particular (this list may not be correct or complete):
is, inline, where, model, for, while, switch, if, else, unsafehavekey_*rules but don't use them;struct, union, static, atomic, and thread_localhavekey_* rulesbut don't appear in thekeywordrule;true, false, as, export, extern, fn, fntype, symbol, theory, needs, using, test, macrodon't havekey_*rules at all.
The first group should be fixed just to improve readability, as it has no effect on the grammar accepted.
As for the second and third groups it may be that you don't want some of these keywords to be excluded from the identifiers, but I think context-sensitive keywords just make things more confusing. I recommend changing them all too, even though this will exclude some code that was formerly legal.
Activity