Repository navigation
clippy 1.99 fails the workspace on double_must_use raised inside #[async_trait] #318
Description
Problem
CI installs the current stable toolchain on every run; there is no rust-toolchain.toml, and check.yml records that as deliberate. Since clippy 1.99.0 reached stable, just rust-clippy fails: asterism-core alone reports 257 errors from clippy::double_must_use, "this function has a #[must_use] attribute with no message, but returns a type already considered as #[must_use]". Every report points at an #[async_trait] attribute, for example on ImportDefinitionRepository in crates/asterism-core/src/domain/repository.rs, and clippy's note says the error originates in that attribute macro: the attribute is part of the macro's expansion, not code written here.
Any pull request whose narrow gate reaches a crate using #[async_trait], and any change that puts every crate in scope (the Justfile, scripts/, the manifest), now fails CI for a reason unrelated to its own diff. Observed on #315 (both the macOS and Windows jobs). The last green run on main predates the toolchain change.
Desired outcome
just rust-clippypasses on clippy 1.99 and on the version the workspace passed before.- The fix either takes an
async-traitrelease that no longer emits the attribute the lint reports, or allows the lint at the narrowest scope that covers the macro's expansion, with the reason written beside the allowance. - Any other lint new in 1.99 that fails the workspace is listed here before it is fixed or allowed.
Constraints
- The toolchain stays unpinned; that policy is recorded in
check.ymland is not what this issue changes.
Activity