8000 Several features are not present in the DictVectorizer after training · Issue #16 · xigt/lgid · GitHub
[go: up one dir, main page]

Skip to content

Several features are not present in the DictVectorizer after training #16

Open

Description

@MackieBlackburn

I found that after training on 98 freki files the DictVectorizer used by models.py doesn't contain the following features:

L-LMm
G-overlap
W-prevclass

This means that these features are not used in training or testing and this may in part account for the low performance. Currently I'm not sure why these features are not making it into the vectors.

Activity

  1. elirnm commented on Aug 16, 2017

    @elirnm
    Contributor

    The L-CR-LMc and L-LMc features are making it into the vectors on my machine.

    L-CR-LMw isn't but that might be because nothing reaches the threshold. This is just running it on the sample file in github, not on a big set.

    G-overlap doesn't work because the g_features method isn't implemented yet. I could do that, but looking at the description of G-overlap I'm not really sure what it's supposed to be measuring.

    L-LMm isn't implemented yet. I can do that.

    I don't think W-prevclass is implemented.

  2. goodmami commented on Aug 17, 2017

    @goodmami
    Member

    As @elirnm said, g-overlap was not implemented. It should be the same as the L-LMw (as I understand it), but with the model (and features) taken from the gloss line rather than the language line.

    L-LMm isn't implemented yet (see #9).

    Neither is W-prevclass, but it is different. W-prevclass uses the predicted value of the previous instance, so it's an online feature (i.e., you can't determine it until you've classified the one before it), but during training you can use the gold label of the previous instance, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0