[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix: "devalue is a lot faster but insecure to use on the server" #6092

Open
1 task done
ywarezk opened this issue Oct 8, 2024 · 2 comments
Open
1 task done
Labels
✅ accepted-PRs-welcome Feature proposal is accepted and ready to work on 📚 documentation / examples Improvements or additions to documentation

Comments

@ywarezk
Copy link
ywarezk commented Oct 8, 2024

Area of Improvement

Why is the following section in the docs correct:

Here superjson is used for uploading and devalue for downloading data because devalue is a lot faster but insecure to use on the server.

that section is located here: https://trpc.io/docs/server/data-transformers

devalue can be insecure if you are using uneval and eval but you can also use stringify and parse in the devalue library to avoid the usage of eval.

I find a transformer example which is just using devalue to be much friendlier than that weird mix of superjson and devalue together

Link to related docs

https://trpc.io/docs/server/data-transformers

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd be down to file a PR implementing the suggested changes!

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@ywarezk ywarezk added the 📚 documentation / examples Improvements or additions to documentation label Oct 8, 2024
@KATT
Copy link
Member
KATT commented Oct 8, 2024

click edit on the page and submit a PR? :)

@KATT KATT added the ✅ accepted-PRs-welcome Feature proposal is accepted and ready to work on label Oct 8, 2024
@KATT
Copy link
Member
KATT commented Nov 1, 2024

cc @ywarezk could you edit docs? there is a button at the bottom of the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ accepted-PRs-welcome Feature proposal is accepted and ready to work on 📚 documentation / examples Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants