-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown checker #226
base: main
Are you sure you want to change the base?
markdown checker #226
Conversation
added parser detected all tables into the MD file collected all link definitions started to add tests
removed husky
changed pacakge publication to private
tools/markdown-checker/lib/parser/__tests__/readMarkdown.test.js
Outdated
Show resolved
Hide resolved
tools/markdown-checker/lib/parser/__tests__/readMarkdown.test.js
Outdated
Show resolved
Hide resolved
tools/markdown-checker/lib/parser/__tests__/readMarkdown.test.js
Outdated
Show resolved
Hide resolved
Adding it in eslint + airbnb configuration can be good for code standard. |
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
added missing newlines
…/proposals into ozer-check-markdown
eslint integration
…check-markdown
refactored index.js splitted some utils functions
|
Not everyone using VSCode. |
Definitely editor-specific stuff isn't a good idea to include. If it's a linter tho, it should be able to run locally via eslint, which would be fine. The trick with an action (or any CI check) is that inevitably someone's going to be blocked by a link going dark when it's unrelated to the change they're making. What we really need is something that can notice a link is dead, and then open up a PR or issue about it. |
@ljharb i think, i can integrate one link-checker on github action on push and scheduled (run once a day) |
@septs how would we be notified when it failed? would that cause PRs to suddenly be blocked? |
@ljharb ye, will a notification, but will not prevent PR. |
adds some refactoring
removes .idea folder
removes html from table heads
@ljharb @littledan @chicoxyzzy final JSON output was created for stage 1. Still, things need to be improved, but let's discuss the output For refreshing memories of what this PR was about |
In addition, you can review the JSON output here. It will be the final result after we are done with that PR |
#140
Discussions: #140 (comment)