8000 Seems to be incompatible with use of `customize` for `mode-line-format`(?) · Issue #33 · tarsius/minions · GitHub
[go: up one dir, main page]

Skip to content

Seems to be incompatible with use of customize for mode-line-format(?) #33

Closed

Description

@WJCFerguson

(minions-mode 1) did not appear to be working for me because I modified my mode-line via customize and start my emacs as a daemon using emacsclient -a "".

I presume that setq-default in the define-minor-mode is not compatible with customize. I'm not sure what the solution is. I'm out of my depth trying to work out what would behave better default-set-variable wasn't it.

Obviously I can work around it by not using customize. Thank you for the package. Not only does it clean up my modeline it speeds up my startup quite significantly as I was using delight which seems remarkably slow.

Activity

  1. tarsius commented on Mar 21, 2022

    @tarsius
    Owner

    This is one of those variables that should not be edited using Custom.

    In essence what happens is:

    (setcar (member 'x var) 'X) ; minions edits the value
    (setq-default var '(a b C)  ; custom *replaces* the value, discarding all previous edits

    You should place the custom-set-variables very early in your init file to change the order in which these things happen. For many variables that is good enough, so do that even though it doesn't fix the issue fully here.

    This will work until you later use custom to edit the variable again. At this point the value contains the edits made by minions. If you save the accumulation of these changes as the new value, minions will later not be able to make the edits it expects to make because they are already there.

  2. WJCFerguson commented on Mar 21, 2022

    @WJCFerguson
    SponsorAuthor

    Thanks - seems like a good call to move my custom file load high up in the init. Perhaps I'm a rare case to hit this, but it could be useful to mention it somewhere as the effect was to just make it look like (minions-mode 1) didn't work.

  3. tarsius commented on Mar 21, 2022

    @tarsius
    Owner

    I don't think Minions is the right place to document this. This affects many packages and it just so happens that you ran into this problem with this package. The documentation for Custom should make this more clear (if it doesn't already do, I haven't looked).

    That being said, since it already talks about similar issues, I added a note to https://github.com/tarsius/minions/wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0