Repository navigation
Notification counter clips envelope when user has a double-digit number of notifications. #78
Description
Got another minor one for ya. The notification count clips the envelope icon when I have >9 notifications.
F6 menu says it's in /resource/layout/steamrootdialog.layout, container SteamRootDialog / CSteamRootDialog, and the selection is Inbox Button / CInboxButton.
I'm able to replicate the issue by setting my Steam to English, so it's not a localisation issue.
Pixelvision² build dated 2016-06-29, Steam build dated 2016-07-08 14:48:42. Windows 7 build 7601 x64. I'm using the Smaller Big Picture Icon and Steam Piston overrides.
The following items in my settings.ini are uncommented:
- Alternative Font
- Tweak: Game Title Background (Library, Details view)
- Tweak: Replace Big Picture Mode Icon (Use Controller Icon)
N.B.: I'm about to clear out the comment notification, so that'll drop me back to 9. If you need to bring it back up to 10, let me know and I'll drop my Steam profile link - comments should be open.
Activity
somini commentedon Jul 14, 2016
Sorry for taking so long to respond, I've been busy.
Once again many thanks for such detailed bug report, we really appreciate it.
I did the easy part, just shifted the » and the counter 5 pixels to the left, should looks like it should solve the problem for less than 99 notifications. I'll ping @CaptainMagma , since I think it's possible to align the text to the right, but I couldn't do it properly.
Fix >=10 notifications overlap
CaptainMagma commentedon Jul 15, 2016
I believe I've commented on this issue previously in the Steam group forums. The original creator of the skin has acknowledged the existence of this bug without ever fixing it. I thought it was because he couldn't figure out a fix for it. And, honestly, I never tried to fix it because I forgot about it and I've never had that many notifications.
How's it looking now after the adjustments made?
It looks like the bug is similar to the one with the family view icon where everything after your notifications doesn't readjust its position properly. Like the family view icon bug, it could just be the Steam client's fault.
EvilJackCarver commentedon Jul 15, 2016
I've got a fresh copy-paste of the steamrootdialog.layout uploaded 4 hours ago I'll need a fresh notification to check (thankfully, only one - I'm down to 9) - I'm sure I could get a few by the morning, but if you want to accelerate the process, you can drop a comment on my steam profile - should be public.
In the meantime, I'm gonna look at the older file and get a diff and pull request ready for the Big Picture Icon override, since I know that much I should be capable of doing.
CaptainMagma commentedon Jul 15, 2016
Sure, I'll drop a comment.
EvilJackCarver commentedon Jul 15, 2016
No dice, I'm afraid - all that succeeded in doing is moving the whole thing over - icon and text.
Just in case my copy-paste botched up, the CRC32 of my local copy is 336B51A3.
CaptainMagma commentedon Jul 15, 2016
Yea, the problem is probably what I thought before. I'll try and mess around with it this weekend but I don't know if both problems can be fixed without completely re-doing the whole top right portion of the skin.
EvilJackCarver commentedon Jul 15, 2016
Alrighty. I'll stay tuned and click around in the F6 menu. If I think of something, I'll let you know.
Might try it locally beforehand, if I can figure out what part of the skin the envelope icon is.
CaptainMagma commentedon Jul 15, 2016
You mean where the actual image file is saved? It's in the graphics folder. The files are inbox and inbox_hover.
EvilJackCarver commentedon Jul 15, 2016
I took a glance at the diff in the commit above and I'm gonna be honest - I can't make heads nor tails of it.
Going off your suggestion, I found that adding a minimum of 5 pixels of blank space to the left of the graphic gives it enough room to clear the notifications for a double-digit amount. I went ahead and made it 7 so it'll clear comfortably.
It's a bit of a heavy-handed fix, and it destroys the kerning at the double-right-chevron after the "x online" bit, but it's a fix nonetheless. I've attached the TGAs, but I'm hesitant on calling it "fixed" because of the kerning issue. New dimensions are 23 wide by 12 tall.
Edit: In the morning, I'm going to revert the steamrootdialog.layout to the one from #77 and see if it fixes the kerning issue - I'd do it now but it's 00:47 and I'm having trouble thinking straight.
notif_icon_fix.zip
Edit 2016-07-15 T 17:42 Z: I reverted back to the steamrootdialog.layout for the smaller Big Picture icon override from Pull #77 (linked above) and now the envelope is realigned with the chevron above the account bit. The chevrons to the left still look a bit off (but I can deal with that).
One thing I realised laying down in bed, however, is that this very well may cause issues with single-digit numbers of notifications since it seems the text is aligned to the left. Push changes at own risk.
Since the original issue is fixed with this change, feel free to close it; I won't since there still lies the chevron bit and I'd rather not decide for you guys whether this is an issue you want to fix or not.
somini commentedon Jul 15, 2016
I found a text-align property to try and align the text to the right side, but it didn't work, I commented on PR #79 .
somini commentedon Jul 15, 2016
For the record, this is what I see when I checkout
pull/79.avsaponchik commentedon Jul 16, 2016
hehe
Black4Blade commentedon Oct 20, 2020
Seeing that currently there are no more numbers, this issue is not relevant anymore, so going to close it up :)