8000 No Steam Proton button · Issue #113 · somini/Pixelvision2 · GitHub
[go: up one dir, main page]

Skip to content

No Steam Proton button #113

Closed
Closed

Description

@ipkpjersi

As you can see in the top left corner of this picture, it says "runs" which means it runs using Steam Proton as I am on Linux, but there is no button for this:

Activity

  1. halbrd commented on Feb 10, 2019

    @halbrd
    Collaborator

    Would you be able to provide a screenshot of what it's supposed to look like (i.e. with the default Steam skin enabled) so we can understand what's not working properly?

  2. ipkpjersi commented on Feb 10, 2019

    @ipkpjersi
    Author

    Hi,

    Sure, I can do that.

    It should look like this for non-official Proton Compatible titles:

    It should look like this for official Proton Compatible titles:

    I hope this clears up any confusion.

    Thanks.

  3. Black4Blade commented on Feb 12, 2019

    @Black4Blade
    Collaborator

    Hey I think I got it fixed
    If you can test it and let me know, it's not perfect at all, will need a little more work, and will need to get in order something else that may be there but just want to know if this does fix the basic problem
    https://github.com/Black4Blade/Pixelvision2/tree/BetaFastFix

    @ipkpjersi

  4. ipkpjersi commented on Feb 14, 2019

    @ipkpjersi
    Author

    It's perfect for me, awesome! Nice job. Hopefully you can make a PR with these fixes and the PR gets merged.

  5. Black4Blade commented on Feb 14, 2019

    @Black4Blade
    Collaborator

    It's perfect for me, awesome! Nice job. Hopefully, you can make a PR with these fixes and the PR gets merged.

    I can manage, got access, not doing it yet, mostly because need to word some things there better :P
    Besides that, it looks completely fine by you? by me it was squashed may have been because the VM was a low res

  6. ipkpjersi commented on Feb 14, 2019

    @ipkpjersi
    Author

    No resolution or stretching issues whatsoever. Looks perfect to me, but I can test it more later tonight.

    edit: I tested it more, seems to be working perfectly fine for me even at various sizes etc.

  7. Black4Blade commented on Feb 24, 2019

    @Black4Blade
    Collaborator

    No resolution or stretching issues whatsoever. Looks perfect to me, but I can test it more later tonight.

    edit: I tested it more, seems to be working perfectly fine for me even at various sizes etc.

    thanks for testing I put a pull request with the fix, just have to make sure its not breaking something else that or any other fix I put there before its merged

  8. Black4Blade commented on Feb 25, 2019

    @Black4Blade
    Collaborator

    Ok merged this should be fixed now
    So closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0