-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.2.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 12 files changed
- 5 contributors
Commits on Mar 15, 2019
-
[chore] Update the license of the chat example (#3410)
There was no obvious reason to use BSD instead of MIT for that very basic chat app. Closes #3411
Configuration menu - View commit details
-
Copy full SHA for 9c1e73c - Browse repository at this point
Copy the full SHA 9c1e73cView commit details
Commits on Sep 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1150eb5 - Browse repository at this point
Copy the full SHA 1150eb5View commit details -
[docs] Fix the default value of the 'origins' parameter (#3464)
Fix documentation about default origins value. The default should read `*:*` instead of `*
Configuration menu - View commit details
-
Copy full SHA for 8227192 - Browse repository at this point
Copy the full SHA 8227192View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d01b2c - Browse repository at this point
Copy the full SHA 4d01b2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf39362 - Browse repository at this point
Copy the full SHA cf39362View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47161a6 - Browse repository at this point
Copy the full SHA 47161a6View commit details
Commits on Jan 4, 2021
-
Due to the recent changes to the Travis CI platform (see [1]), we will now use GitHub Actions to run the tests. Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
Configuration menu - View commit details
-
Copy full SHA for 6fa026f - Browse repository at this point
Copy the full SHA 6fa026fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3951a79 - Browse repository at this point
Copy the full SHA 3951a79View commit details -
fix: properly overwrite the query sent in the handshake
The `query` option of the Manager had the priority over the one of the Socket instance, which meant updating the Socket#query object on the client-side was not reflected in the Socket#handshake object on the server-side. Please note that the behavior of the `query` option is still a bit weird in Socket.IO v2, as it only applies to non-default namespace. This is fixed in v3: - https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#Add-a-clear-distinction-between-the-Manager-query-option-and-the-Socket-query-option - https://socket.io/docs/v3/middlewares/#Sending-credentials Fixes #3495
Configuration menu - View commit details
-
Copy full SHA for d33a619 - Browse repository at this point
Copy the full SHA d33a619View commit details -
fix(security): do not allow all origins by default
BREAKING CHANGE: previously, all origins were allowed by default, which meant that a Socket.IO server sent the necessary CORS headers (`Access-Control-Allow-xxx`) to any domain by default. Please note that you are not impacted if: - you are using Socket.IO v2 and the `origins` option to restrict the list of allowed domains - you are using Socket.IO v3 (disabled by default) This commit also removes the support for '*' matchers and protocol-less URL: ``` io.origins('https://example.com:443'); => io.origins(['https://example.com']); io.origins('localhost:3000'); => io.origins(['http://localhost:3000']); io.origins('http://localhost:*'); => io.origins(['http://localhost:3000']); io.origins('*:3000'); => io.origins(['http://localhost:3000']); ``` To restore the previous behavior (please use with caution): ```js io.origins((_, callback) => { callback(null, true); }); ``` See also: - https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS - https://socket.io/docs/v3/handling-cors/ - https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#CORS-handling Thanks a lot to https://github.com/ni8walk3r for the security report.
1Configuration menu - View commit details
-
Copy full SHA for f78a575 - Browse repository at this point
Copy the full SHA f78a575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 873fdc5 - Browse repository at this point
Copy the full SHA 873fdc5View commit details
Commits on Jan 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a169050 - Browse repository at this point
Copy the full SHA a169050View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b8697 - Browse repository at this point
Copy the full SHA e6b8697View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.2.0...2.4.1