8000 Missing "make check" · Issue #6 · sipa/miniscript · GitHub
[go: up one dir, main page]

Skip to content

Missing "make check" #6

Open
Open

Description

@practicalswift

Missing make check.

make check would simply run the test suite (miniscript_tests.cpp) :-)

Activity

  1. sipa commented on Aug 28, 2019

    @sipa
    Owner

    That won't work; the tests rely on the rest of the Bitcoin Core source code.

  2. practicalswift commented on Aug 28, 2019

    @practicalswift
    ContributorAuthor

    @sipa Perhaps a short note on how to setup the project (including fetching a copy of the Bitcoin Core source code) to make testing miniscript easy would be enough?

  3. practicalswift commented on Aug 29, 2019

    @practicalswift
    ContributorAuthor

    Perhaps an alternative would be to add a new smaller test suite that doesn't depend on the rest of the Bitcoin Core source code and would be runnable as make check out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0