Repository navigation
Pymodbus integration is outdated/broken #39
Description
While trying to get the modbus part of example s3-2017 running, I've noticed that minicps is written against pymodbus version 1.3.2, which is very out of date (current pymodbus uses a different structure / api). In addition, installing pymodbus==1.3.2 doesn't work for any python versions above 3.6 as it's using the reserved keyword async.
Activity
noleti commentedon Jun 14, 2025
This is not fixed so far, I saw what looked like related patches in #26 (i.e., async can be replaced by asynchronous).
noleti commentedon Jun 17, 2025
I looked into this, and
s3-2017is obviously pretty broken and not intended to be ready to be run out of the box. It's essentially the code we used for an event in 2017 and wasn't updated since then. I agree it would be nice to have a simple modbus use case, which could potentially be built out of content in #26. Overall integration does not seem to be too complicated.I will leave this issue open for now. If someone wants to contribute a PR (e.g. a "modbus-toy" example), please do so!