[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible (or not to hard) to have the bot ping a github handle on a PR if it affects specific SymPy modules? #91

Open
moorepants opened this issue Sep 22, 2020 · 7 comments
Open

Is it possible (or not to hard) to have the bot ping a github handle on a PR if it affects specific SymPy modules? #91

moorepants opened this issue Sep 22, 2020 · 7 comments

Comments

@moorepants
Copy link
Member

I'd like the bot to ping @sympy/mechanics on any PR that effects files in sympy.physics.vector or sympy.physics.mechanics.
@moorepants
Copy link
Member Author

I really can't keep up with the notifcations in github, and really just want to be informed of changes in some sympy modules (probably physics.continuum_mechanics, control, and others I've helped with).

@moorepants
Copy link
Member Author

I found this: https://app.github-file-watcher.com/ which might fit my needs.

@moorepants
Copy link
Member Author

There is also the Github CODEOWNERS file that may help. I opened this: sympy/sympy#20130

@asmeurer
Copy link
Member

I think CODEOWNERS does the job here. Is there anything that doesn't do that the bot should?

@moorepants
Copy link
Member Author

I'd like to get an email notification, ideally.

@asmeurer
Copy link
Member

Does CODEOWNERS not do that? I haven't used it before, but if all it does is request a review, it should send a notification, assuming you have notifications enabled for review requests.

@moorepants
Copy link
Member Author

Ok, I'll check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asmeurer @moorepants