Fix typo and tell_pbar #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlyaGomaa can you review my PR. |
|
This CI-staging should not be failing based on my changes. Seems like dataset-integration failure is common among PRs. |
|
@patel-lay yes true, not sure why though, will fix this and re-run CI in your PR and if all goes will i'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#871
#879
Changes proposed
Check if msg is empty or not before calling pbar_sender_pipe()
Typo in main screen
"[Main] " overwrote the first few character("Total A"). Adding [Main] is a simple fix but not permenant. I believe more analysis is required to understanding the reason of overwriting.
Also the whole statement is printed once after "Flow Processed" line, but then disappears. Careful observation is required to notice this.
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
Included in change proposed.