-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe send a PR to BH instead ... #212
Comments
Well, it is not just as simple as sending a PR to BH, which we had done before and for which we appreciated your help. But here for some reason I can recall now, we have 9c0e10b. |
gcc test for up to 4.6. Hm. A Windows issue? |
Sorry @eddelbuettel ; I didn't make a PR yet because I wasn't sure of what the right fix was and didn't want to introduce a hack that worked for rstan but not some other package. |
Well maybe we should carry that forward as BH is used by 25+ packages now ... |
If you think it would be helpful to take that unused.hpp file for BH, go ahead. Also, the actor.hpp file in boost_not_in_BH I am not sure about either. We changed that in Stan to work around a compiler error with the Intel C++ compiler, and it didn't adversely affect our unit tests, but I have no idea how it would affect anyone else's code. |
It's a trade-off. I want useful enhancements and corrections, but I don't want to be caretaker of a bunch of isolated patches. |
If you still care, BH 1.60.0-1 is now on CRAN with, inter alia, Boost phoenix. |
... of using a poetically named path?
BH is not exactly a closed system as even a casual perusal of its NEWS.Rd file will tell you. [ Apologies for the unrendered Rd file; the version of NEWS.Rd on CRAN missed the last update. ]
The text was updated successfully, but these errors were encountered: