Poolpost nearby implementation #537
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay sorry for all the extra commits; the backend stuff is now pretty much tested on my end. I'll write some formal tests later. Next up is the frontend. I'm not terribly familiar with the frontend so this may take a bit. |
this implementation was *heavily* cherry-picked from PR rr-#403.
|
And that should be most of the frontend code (wound up lifting the majority of it wholesale from #403). I'll write some unit tests later, and then it should be ready for review. |
|
This is very slow when any entry is unavailable, such as on single-post pools, or edges of pools (first/last post). Undefined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to redo a component of #403 (which is seemingly abandoned for 2 years now and had some choice comments). Specifically, this PR aims to introduce the pool navigation elements to the post page.
Right now it is still in draft (I need to test this, write unit tests and add the frontend elements) but I'm making this draft PR to inform people on the status of the implementation.
I might choose to implement other elements of #403 in other PRs (although I'd probably do element 3 differently and not do element 2 at all, but we'll see on that one), but I really want this component functional.