8000 memory leak issue · Issue #9 · rolinh/libgwavi · GitHub
[go: up one dir, main page]
Skip to content

memory leak issue #9

New issue
New issue
Open
Open
memory leak issue#9

Description

@rockcarry
rockcarry
opened on Apr 25, 2019

i review the code, and find out, there are memory leaks in function gwavi_open and gwavi_close.

Activity

  1. mtiraouiDH commented on Sep 10, 2019

    @mtiraouiDH
    mtiraouiDH
    on Sep 10, 2019

    The memory leak is due to not free'ing the buffer used to write frames. The problem is, at least in the example provided with source, is that 5 memory allocation was declared but only 4 free was called !
    Either free the buffer after calling the gwavi_add_frame function or add free(buffer) inside that function befor return'ing. That should stop memory leaks.

  2. rolinh commented on Sep 18, 2019

    @rolinh
    rolinh
    on Sep 18, 2019
    Owner

    Hi and thanks for reporting this. I will try to have a look once but as I do not use this library anymore I don't have a very high incentive to do it. I'll be happy to review a PR though :)

  4. rolinh commented on Jun 24, 2020

    @rolinh
    rolinh
    on Jun 24, 2020
    Owner

    @flok99 Your PR does not decouple features/fixes. I probably want to merge your memory leak fix but not what is related to debian packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      0