8000 Benchmark regression: checkpoint (main) · Issue #574 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

Benchmark regression: checkpoint (main) #574

Closed as not planned
Closed as not planned

Description

@github-actions

Bencher flagged these benchmarks in the nightly run (checkpoint, main) on two runs in a row:

  • checkpoint/100k
  • checkpoint/1m

Branch: main
Run: https://github.com/project-minigraf/minigraf/actions/runs/38373154795
Previous run: https://github.com/project-minigraf/minigraf/actions/runs/38225035471

Please review the Bencher dashboard to confirm the regression.

Activity

  1. adityamukho commented on Oct 13, 2026

    @adityamukho
    Collaborator

    Not a regression: the same step as #561/#562/#573. Bencher on main: checkpoint/100k ~4 ms → ~2.2 s and checkpoint/1m ~40 ms → ~25 s, starting exactly at a861e55 (v2.0.5, which contains #540) and flat since (72d847e, d604cc4). Before #540 the usize::MAX close-time save still wrote the .graph, so the fixture's checkpoint was a no-op; the new numbers are the real checkpoint cost. #568 (30-run window) will absorb the step after a few more runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceBenchmark performance regressions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0