8000 Pre-commit support · Issue #104 · princjef/gomarkdoc · GitHub
[go: up one dir, main page]

Skip to content

Pre-commit support #104

Open
Open

Description

@hypercall88

Hello! Very nice tool. I just wanted to request official support for pre-commit if at all possible as this would be a very nice integration if working appropriately.

This team from turo has attempted it:
https://github.com/turo/pre-commit-hooks

The problem is the re-embedding seems to always cause a pre-commit failure and re-indexing of the main README.md, so there's an infinite recursion of failure.

Activity

  1. princjef commented on Aug 18, 2023

    @princjef
    Owner

    Hi @desebjohnston, pre-commit is definitely a good use case for this tool. I'm not familiar with the project you mentioned, but I would expect the command to run the same way within a pre-commit hook as it runs under normal execution. If you could provide some details of how gomarkdoc is being invoked or possibly an example where the problematic behavior you're seeing occurs, that will help identify any issues so they can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0