Repository navigation
Make puppeteer peerDependency #108
Description
If I use minimalcss in react-snap it will download two copies of puppeteer. If we make minimalcss-core without CLI and with peerDependency puppeteer and minimalcss with CLI and with puppeteer+minimalcss-core dependency I will be able to use minimalcss-core in react-snap with one copy of puppeteer
Todo this we probably want to use monorepo, see https://github.com/lerna/lerna and https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/
Activity
peterbe commentedon Jan 29, 2018
I have only read about workspaces but if it means we can have one
package.jsonfor the cli and onepackage.jsonfor the "core", that would be awesome.But what does it mean in terms of npmjs.com?
I do like the idea of splitting the code into smaller parts but I'm quite pessimistic about breaking up the repo.
stereobooster commentedon Jan 29, 2018
Yes.
It means you will have two separate npm packages, but they will live in one repo for development convenience.
Create-react-app does this, for example.
peterbe commentedon Jan 29, 2018
Neat! I like this.
Do I need to run
jestinside each directory? (not a problem)stereobooster commentedon Jan 29, 2018
Yes, but there will be one top level
package.jsonyou can create one task which will run all tests in subdirectories