[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11 lib needed, perhaps this to install instructions? #83

Open
Ran4 opened this issue May 27, 2020 · 3 comments
Open

x11 lib needed, perhaps this to install instructions? #83

Ran4 opened this issue May 27, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Ran4
Copy link
Ran4 commented May 27, 2020

Users of this library is likely to stumble upon this issue, at least in linux environments.

servo/rust-xlib#44

It's trivially fixable with sudo apt install libx11-dev and easily googleable, but perhaps adding this to README.md could be helpful?
@parasyte
Copy link
Owner
parasyte commented May 28, 2020 •
edited
Loading

Is this a build dependency for the crate (library), or for the examples?

@parasyte parasyte added the question Usability question label May 28, 2020
@parasyte parasyte mentioned this issue May 28, 2020
Closed
@parasyte
Copy link
Owner

From a quick survey, it seems like this is actually a bug in the depths of wgpu. See the linked issue for details.

I'm happy to document the required dependency, but in the future I would be more interested in documenting how to disable the requirement by setting a feature flag. ;)

@parasyte parasyte added good first issue Good for newcomers upstream bug Bug appears to originate in an upstream dependency documentation Improvements or additions to documentation and removed question Usability question upstream bug Bug appears to originate in an upstream dependency labels May 28, 2020
@parasyte
Copy link
Owner

The upstream issue has been resolved, and consumers of wgpu will be able to opt-in to libx11 if they need it, using something like the following Cargo.toml entry:

[target.'cfg(all(unix, not(target_os = "ios"), not(target_os = "macos")))'.dependencies]
gfx-backend-vulkan = { version = "0.5", features = ["x11"] }

I'll leave this ticket open to track the documentation work... which won't be viable to begin until we update wgpu.

@harrysarson harrysarson mentioned this issue Jun 7, 2020
Closed
@AnEnigmaticBug AnEnigmaticBug mentioned this issue Jan 1, 2021
Closed
@parasyte parasyte mentioned this issue Feb 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parasyte @Ran4