8000 remove new method promoters · Issue #213 · pyranges/pyranges1 · GitHub
[go: up one dir, main page]

Skip to content

remove new method promoters #213

Open

Description

@marco-mariotti

All methods have the shape of fundamental operations that may act on any time of ranges, and naming is chosen to reflect that. Also, names are chosen to reflect the "genome arithmetics" that was done, and must avoid functional names since they do not have precise definitions. Anything that does not fit in this general framework must go in a submodule.

New method promoters() breaks just that. A promoter is not an arbitrary region near the TSS; it is a functional unit that varies for each gene, and it is defined by its binding partners and genetic behavior.

I recommend deleting it altogether, and simply add one more docstring example to current method .five_end() to showcase how to obtain the same result. I understand the rationale was to have a genomicranges analog so we may mention genomicrange method in there, facilitating finding this method when searching documentation.

The new example would look something like

gr.five_end().extend_ranges(ext_5=2000, ext_3=199)

or

gr.five_end(group_by='transcript_id').extend_ranges(ext_5=2000, ext_3=199, group_by='transcript_id')

Activity

  1. endrebak commented on Nov 3, 2026

    @endrebak
    Collaborator

    Fine with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0