8000 BUG: CellAligment bug with enclosed tessellation · Issue #252 · pysal/momepy · GitHub
[go: up one dir, main page]

Skip to content

BUG: CellAligment bug with enclosed tessellation #252

Open

Description

@AleFeli

When computing CellAlignment on enclosed tessellation, a Length mismatch error is generated. This seems to depend on the fact that enclosed tessellation, unlike "traditional" tessellation features polygons that do not contain building geometries. A way around this could be excluding empty cells or assigning NaN/0 values?

Activity

  1. added this to the 0.4.2 milestone on Jan 14, 2021
  2. changed the title [-]CellAligment bug with enclosed tessellation[/-] [+]BUG: CellAligment bug with enclosed tessellation[/+] on Jan 14, 2021
  3. martinfleis commented on Jan 24, 2021

    @martinfleis
    Member

    Hey @AleFeli, I am not able to reproduce this. With the following code, which results in 144 buildings and 153 cells, CellAlignment works as intended. Can you send the full Traceback or find out which situation causes the failure?

    import geopandas as gpd
    import momepy as mm
    
    roads = gpd.read_file(mm.datasets.get_path('bubenec'), layer='streets')
    blg = gpd.read_file(mm.datasets.get_path('bubenec'), layer='buildings')
    
    enclosures = mm.enclosures(roads, gpd.GeoSeries([roads.unary_union.convex_hull]))
    et = mm.Tessellation(blg, 'uID', enclosures=enclosures)
    tess = et.tessellation
    
    ca = mm.CellAlignment(blg, tess, mm.Orientation(blg).series, mm.Orientation(tess).series, 'uID', 'uID')
  4. AleFeli commented on Jan 25, 2021

    @AleFeli
    ContributorAuthor

    No failure in this case. I will try to find out more using the data I was working with when I found the issue.

  5. removed this from the 0.4.2 milestone on Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0