8000 Add ability to accept or reject changes individually · Issue #568 · loot/loot · GitHub
[go: up one dir, main page]

Skip to content

Add ability to accept or reject changes individually #568

Open

Description

@Thallassa

This is something mator and I had discussed as desirable, and I mentioned it to Freso and he said I should put it here as a feature request.

Basically, when LOOT decides to move mods around, you can either click "apply" (thereby accepting all its changes), or close it (thereby accepting none of its changes).

It would be nice to be able to accept some changes, but override others (without necessarily making a meta rule every time, especially as I've had issues with circular meta data in the past...)

Activity

  1. Freso commented on Apr 20, 2016

    @Freso
    Member

    I really like this idea. I'm imagining it kind of similar to how a git add --patch (or git commit --patch) works, but @WrinklyNinja knows better how it could actually work in LOOT. Combined with #377 and/or #555 it would make LOOT much more flexible.

    It should possibly be a toggle though.

  2. Ortham commented on Apr 20, 2016

    @Ortham
    Member

    It's a neat idea, and upon first thought is technically feasible, but do you have any suggestions for what the UX would be like?

  3. Thallassa commented on May 19, 2016

    @Thallassa
    Author

    ... This was a month ago? Oh man, I'm sorry.

    It kind of depends on how #377 might look, but one thought I had was highlighting the plugins that changed position, possibly indicating how many positions they changed and in which direction (like red up arrows and green down arrows with a number next to them), and then a check mark to accept the change and a red box to decline.

    Could be simplified with just an "accept" box next to each changed plugin.

    My understanding is that the next version will only move plugins that need to move (current version moves plugins that don't need to move, alphabetically), so that would simplify it as only... oh, I dunno... like 60% of plugins would need to have changes individually applied during use.

  4. Ortham commented on May 19, 2016

    @Ortham
    Member

    My understanding is that the next version will only move plugins that need to move

    That change happened in v0.7.

  5. Thallassa commented on May 19, 2016

    @Thallassa
    Author

    It did? I'm using.... 8.1... I'm bad at versions and my plugins are still sorting alphabetically, when there are no particular rules. Certainly every single plugin I've looked at, moved.

  6. changed the title [-]Ability to accept changes or ignore them individually[/-] [+]Add ability to accept or reject changes individually[/+] on Feb 3, 2022
  7. Ortham commented on May 9, 2026

    @Ortham
    Member

    LOOT now has a dialog for viewing the load order changes after sorting:

    Image

    I think this could be extended to allow individual changes to be undone, e.g. by having undo buttons next to each of the plus and minus icons. Since every removal is an addition somewhere else, undoing one would automatically undo the corresponding change.

    The thing I'm a bit stuck on though is that this manual customisation would need to be redone every time that you sort with LOOT, which doesn't seem like a good user experience. I feel like there's a gap in the functionality there and there needs to be some way that the rejection of a change can be automatically turned into metadata to persist that rejection, but I don't think that's possible in practice. E.g. if plugin B now loads after plugin A because A is now a master of B when it wasn't before, that can't be countered with user metadata, and masterlist metadata is is similarly not overridable (besides group memberships).

    Even for cases where it would be allowed, it's hard to infer intent from a rejection: if A was loading at index X but is now loading at index X - Y, then it could be rejected because the user wants it to load after any of the Y plugins between its old and new positions. The easy thing would be to just add load after metadata to A saying that it needs to load after whatever plugin is at X - 1, but is that correct? Maybe that's not actually what's important and it's actually the plugin at X - 4 (assuming Y > 4) that plugin A needs to load after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0