8000 mask_logits in layer.py · Issue #43 · localminimum/QANet · GitHub
[go: up one dir, main page]

Skip to content
< 8000 link rel="modulepreload" href="https://github.githubassets.com/assets/84656-83eb10da3d6550df.js" crossorigin="anonymous" />

mask_logits in layer.py #43

Open
Open

Description

@zhaoluffy

I think the line "return inputs + mask_value * (1 - mask)" should be "return inputs*mask + mask_value * (1 - mask)"

Activity

  1. localminimum commented on Oct 26, 2018

    @localminimum
    Owner

    You are correct, however, I believe that the difference is very minuscule (probably even smaller than a floating point epsilon) so I saw no point in fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0