Repository navigation
Rocky 9.4 make issues #29
Description
Hi guys, I'm trying to use thinklmi to set the boot order, but we are having issues with make.
We also tried efibootmgr, but that is not working for us either to set boot order.
Thanks
[root@dumpster-fire thinklmi-kernel]# neofetch
##### root@dumpster-fire
####### ----------------------------------
##O#O## OS: Rocky Linux 9.4 (Blue Onyx) x86_64
####### Host: XXXXXXXXXX ThinkStation P620
########### Kernel: 5.14.0-427.22.1.el9_4.x86_64
############# Uptime: 8 days, 3 hours, 35 mins
############### Packages: 2061 (rpm)
################ Shell: bash 5.1.8
################# Resolution: 1280x1024
##################### CPU: AMD Ryzen Threadripper PRO 3995WX s (128) @ 2.700GHz
##################### GPU: NVIDIA RTX A6000
################# Memory: 4473MiB / 257037MiB
[root@dumpster-fire thinklmi-kernel]#
[root@dumpster-fire thinklmi-kernel]# make
make -C /lib/modules/5.14.0-427.22.1.el9_4.x86_64/build M=/root/thinklmi/thinklmi-kernel modules
make[1]: Entering directory '/usr/src/kernels/5.14.0-427.22.1.el9_4.x86_64'
CC [M] /root/thinklmi/thinklmi-kernel/think-lmi.o
/root/thinklmi/thinklmi-kernel/think-lmi.c: In function ‘think_lmi_set_bios_settings’:
/root/thinklmi/thinklmi-kernel/think-lmi.c:397:20: warning: passing argument 1 of ‘strreplace’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
397 | strreplace(settings,'\\','/');
| ^~~~~~~~
In file included from ./include/linux/bitmap.h:11,
from ./include/linux/cpumask.h:12,
from ./include/linux/smp.h:13,
from ./include/linux/lockdep.h:14,
from ./include/linux/mutex.h:17,
from ./include/linux/kernfs.h:12,
from ./include/linux/sysfs.h:16,
from ./include/linux/kobject.h:20,
from ./include/linux/of.h:17,
from ./include/linux/irqdomain.h:36,
from ./include/linux/acpi.h:13,
from /root/thinklmi/thinklmi-kernel/think-lmi.c:29:
./include/linux/string.h:172:24: note: expected ‘char *’ but argument is of type ‘const char *’
172 | char *strreplace(char *s, char old, char new);
| ~~~~~~^
In file included from ./include/linux/linkage.h:7,
from ./include/linux/kernel.h:8,
from ./include/linux/list.h:9,
from ./include/linux/kobject.h:19,
from ./include/linux/of.h:17,
from ./include/linux/irqdomain.h:36,
from ./include/linux/acpi.h:13,
from /root/thinklmi/thinklmi-kernel/think-lmi.c:29:
/root/thinklmi/thinklmi-kernel/think-lmi.c: In function ‘think_lmi_chardev_initialize’:
./include/linux/export.h:17:22: error: passing argument 1 of ‘class_create’ from incompatible pointer type [-Werror=incompatible-pointer-types]
17 | #define THIS_MODULE (&__this_module)
| ~^~~~~~~~~~~~~~~
| |
| struct module *
/root/thinklmi/thinklmi-kernel/think-lmi.c:809:35: note: in expansion of macro ‘THIS_MODULE’
809 | tlmi_class = class_create(THIS_MODULE, "char");
| ^~~~~~~~~~~
In file included from ./include/linux/device.h:31,
from ./include/linux/acpi.h:15,
from /root/thinklmi/thinklmi-kernel/think-lmi.c:29:
./include/linux/device/class.h:230:54: note: expected ‘const char *’ but argument is of type ‘struct module *’
230 | struct class * __must_check class_create(const char *name);
| ~~~~~~~~~~~~^~~~
/root/thinklmi/thinklmi-kernel/think-lmi.c:809:22: error: too many arguments to function ‘class_create’
809 | tlmi_class = class_create(THIS_MODULE, "char");
| ^~~~~~~~~~~~
In file included from ./include/linux/device.h:31,
from ./include/linux/acpi.h:15,
from /root/thinklmi/thinklmi-kernel/think-lmi.c:29:
./include/linux/device/class.h:230:29: note: declared here
230 | struct class * __must_check class_create(const char *name);
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:299: /root/thinklmi/thinklmi-kernel/think-lmi.o] Error 1
make[1]: *** [Makefile:1934: /root/thinklmi/thinklmi-kernel] Error 2
make[1]: Leaving directory '/usr/src/kernels/5.14.0-427.22.1.el9_4.x86_64'
make: *** [Makefile:11: default] Error 2
[root@dumpster-fire thinklmi-kernel]#
Activity
kean0048 commentedon Feb 2, 2025
Hi @aztlanla,
If you supply info is that your used env, I think it's lower than the lowest request of Linux kernel version, the lowest version requested in the README is written as 5.17 onwards. please tested upper that version.
Thanks.
mrhpearson commentedon Feb 11, 2025
Don't use this project with Rocky9 - support is built into the kernel already.
Go to /sys/class/firmware-attributes/thinklmi - and you can change the boot order using attributes/BootOrder
Documentation here: https://github.com/torvalds/linux/blob/master/Documentation/ABI/testing/sysfs-class-firmware-attributes
aztlanla commentedon Feb 13, 2025
Thank you, will test these out.