You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Read-only scripts and SCRIPT LOAD move the replication offset (a SELECT is propagated for them) #705
Found reviewing #699. A read-only script's SELECT is propagated as a bare SELECT n: two EVAL_RO calls that SELECT moved the master offset by 46 bytes, and SCRIPT LOAD moves it too, while Redis's offset stays at 0 for both. No write can land in the wrong database (writes carry their own SELECT), but replicas and WAIT see offset changes for commands that wrote nothing. Fix: don't propagate a SELECT from a script that wrote nothing (handler.rs, the commands_for_propagation block, ~line 830).
Tagged good first issue: the fix is in one place (handler.rs, the commands_for_propagation block around line 830: don't propagate a script's SELECT when the script wrote nothing). A good PR adds a test that runs EVAL_RO with a SELECT and SCRIPT LOAD and checks master_repl_offset in INFO replication doesn't move, the same as Redis 8.10. Comment here before starting.
Activity
murtazayusuf commentedon Nov 14, 2026
Tagged good first issue: the fix is in one place (handler.rs, the commands_for_propagation block around line 830: don't propagate a script's SELECT when the script wrote nothing). A good PR adds a test that runs EVAL_RO with a SELECT and SCRIPT LOAD and checks
master_repl_offsetin INFO replication doesn't move, the same as Redis 8.10. Comment here before starting.fix(replication): scripts that write nothing, SELECT and SCRIPT LOAD …
Replication: drop the SELECT/SCRIPT propagation left over from #827