8000 Flaky: eviction test allkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up counts one key short (2999 vs 3000) · Issue #509 · kividbio/kividb · GitHub
[go: up one dir, main page]

Skip to content

Flaky: eviction test allkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up counts one key short (2999 vs 3000) #509

Open

Description

@murtazayusuf

tests/eviction.rs allkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up (added with #492) failed once in CI on #507 at line 1609: left + evicted was 2999, expected 3000.

The test reads evicted_keys while the limit still applies, then calls lift_the_limit(), then reads DBSIZE. Background eviction can drop one more key between the first read and the lift, so the sum falls short. No key is lost unaccounted for.

Fix: read evicted after lift_the_limit(), or read both after the limit is lifted and eviction has settled.

cc @Parikalp-Bhardwaj, since it's from #492.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0