Flaky: eviction test allkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up counts one key short (2999 vs 3000) · Issue #509 · kividbio/kividb · GitHub
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Flaky: eviction test allkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up counts one key short (2999 vs 3000) #509
tests/eviction.rsallkeys_lru_keeps_sets_under_the_limit_and_their_usage_adds_up (added with #492) failed once in CI on #507 at line 1609: left + evicted was 2999, expected 3000.
The test reads evicted_keys while the limit still applies, then calls lift_the_limit(), then reads DBSIZE. Background eviction can drop one more key between the first read and the lift, so the sum falls short. No key is lost unaccounted for.
Fix: read evicted after lift_the_limit(), or read both after the limit is lifted and eviction has settled.
Activity