8000 Relative hash-field TTLs are sent to replicas up to 1 ms earlier than the master's own deadline · Issue #489 · kividbio/kividb · GitHub
[go: up one dir, main page]

Skip to content

Relative hash-field TTLs are sent to replicas up to 1 ms earlier than the master's own deadline #489

Open

Description

@murtazayusuf

script_feed::now_ms (src/replication/script_feed.rs, around line 320) cuts the current time to a whole millisecond. It is used to turn a relative TTL into the absolute time the replication feed sends, for HEXPIRE/HPEXPIRE and HSETEX/HGETEX EX/PX. So a replica and the AOF can get a deadline up to about 1 ms earlier than the one the master holds.

Expected: use the same exact conversion as #467/#488 (FieldClock), so the absolute time sent is never earlier than the master's deadline.

Related: #415 (how field expiry is propagated). Found while reviewing #488.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0