Repository navigation
Replies: 1 comment 3 replies
|
I think it's a natural thing to support, and we shouldn't remove it. I've used it a few times for quick experimentations myself (obviously a long time ago, as it seems to have been broken for a while), and could also imagine it would be useful if you are deploying multiple extensions, where one extension has a provider with a high priority, but you'd like to use a different one. If needed this is something we could test easily with the new test framework. Just do a test with a custom provider and custom server config. Would take a few minutes to write the test. Only downside is it obviously requires restarting Keycloak. As a side-note the new test framework also let's us introduce new test modules easily, so we could have |
|
@stianst and to clarify your situation couldn't be addressed by using just the provider option? That is both providers are still needed individually and the preferred one is needed by getProvider(class)? |
Didn't think about that. Honestly I can't think of any providers that should support multiple providers while at the same time have a default. The code mostly looks-up either a specific provider (i.e. from config in realm) or it just gets the default provider. So, you are right could just do this https://www.keycloak.org/server/configuration-provider#_configuring_a_single_provider_for_an_spi instead. |
|
This also relates to #9832 - using the provider option, instead of a default provider, further optimizes what providers are init'd. After looking over more usage scenarios the one that first stands out is PasswordHashProvider - a PasswordPolicy is allowed to optionally specify an algorithm. If not specifed, then the default will be used. That seems to be mostly addressed by factory ordering, but there would be case to be made for configuring it at build time - so a default provider concept is still needed. |
Uh oh!
There was an error while loading. Please reload this page.
#41677 highlighted that configuring a default provider is not something that we do in our own testsuite nor must be common for those following the bleading edge of Keycloak.
It is useful only in a specifc sitation:
Can the community add comments on their usage of a default provider?
All reactions