You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's probably a good question for the community once the RFC is adopted, the options are:
1. make Alejandra follow the suggested style
2. make Alejandra keep its existing style (there will always be an audience for this style)
3. archive all alternative formatters so the community only has 1 option available
As I understand 3 is a non-goal, the formatter implementation is supposed to be considered more of a standard specification for formatting, so different implementations could exist as well, 1. Would be the most optimal.
The main intention behind making it a standard is to not make the implementation the standard. This allows some room for both bug fixes and minor improvements, but it also makes it clear which changes need to go though another RFC.
And while Nixpkgs will have to use the official formatter, there's no problem with other standard-complient formatters existing. It would also be possible to change out the underlying implementation of the official formatter (as long as it's standards-compliant).
But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.
I disagree on this end, I think alejandra should adopt the standard, but some formatters, of course, can be archived like nixpkgs-fmt. Since that had one goal in mind, alejandra is more broad and widely used in the community (including myself) so I think its best to continue supporting it and change it to adhere to the RFC.
If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.
If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.
What's wrong with Alejandra that makes it harder to adher to RFC0166?
As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.
Reacted by Matt Sturgeon, notohh, Noah Biewesch, Kaktus, Vladimir Fetisov, ورد, Gabgobie and Benedikt Müller
As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.
After trying nixfmt-rfc-style, I have decided to keep using alejandra in my personal projects. My opinion is that it is ok to have different formatters to choose from, that don't comply with the "standard"
Reacted by Maeve Rubek, Gabriel Fontes, Matt Sturgeon, Kaktus, Vladimir Fetisov and Gabgobie
Activity
[-]Adhere to RFC101 formatting[/-][+]Adhere to RFC166 formatting[/+]nyabinary commentedon Nov 15, 2023
cc: @kamadorueda
kamadorueda commentedon Nov 15, 2023
It's probably a good question for the community once the RFC is adopted, the options are:
nyabinary commentedon Nov 15, 2023
As I understand 3 is a non-goal, the formatter implementation is supposed to be considered more of a standard specification for formatting, so different implementations could exist as well, 1. Would be the most optimal.
infinisil commentedon Nov 15, 2023
The main intention behind making it a standard is to not make the implementation the standard. This allows some room for both bug fixes and minor improvements, but it also makes it clear which changes need to go though another RFC.
And while Nixpkgs will have to use the official formatter, there's no problem with other standard-complient formatters existing. It would also be possible to change out the underlying implementation of the official formatter (as long as it's standards-compliant).
infinisil commentedon Nov 15, 2023
But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.
nyabinary commentedon Nov 15, 2023
I disagree on this end, I think alejandra should adopt the standard, but some formatters, of course, can be archived like nixpkgs-fmt. Since that had one goal in mind, alejandra is more broad and widely used in the community (including myself) so I think its best to continue supporting it and change it to adhere to the RFC.
piegamesde commentedon Dec 4, 2023
If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.
nyabinary commentedon Dec 19, 2023
What's wrong with Alejandra that makes it harder to adher to RFC0166?
[-]Adhere to RFC166 formatting[/-][+]Adhere to RFC0166 formatting[/+][-]Adhere to RFC0166 formatting[/-][+]Adhere to [RFC 0166] formatting[/+]infinisil commentedon Dec 20, 2023
We recorded some meetings notes about that here
nyabinary commentedon Feb 3, 2024
Nix Formatter is now out for testing in nixpkgs.
https://discourse.nixos.org/t/call-for-testing-nix-formatter/39179/
nyabinary commentedon Mar 19, 2024
@kamadorueda
The time is now to decide I guess, since NixOS/rfcs#166 got officially merged, and their now a tracking issue for nixfmt: NixOS/nixfmt#153
justinrubek commentedon Apr 16, 2024
As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.
nyabinary commentedon Apr 16, 2024
We could have different modes tbf
MattSturgeon commentedon Apr 16, 2024
Is anyone actually going to work on and maintain that when there's already alternative formatting tools out there?
It seems to me that alejandra has different goals to RFC 166. If so this should be considered a "won't fix".
viperML commentedon May 2, 2024
After trying nixfmt-rfc-style, I have decided to keep using alejandra in my personal projects. My opinion is that it is ok to have different formatters to choose from, that don't comply with the "standard"