8000 Adhere to [RFC 0166] formatting · Issue #404 · kamadorueda/alejandra · GitHub
[go: up one dir, main page]

Skip to content

Adhere to [RFC 0166] formatting #404

Open

Description

Activity

  1. changed the title [-]Adhere to RFC101 formatting[/-] [+]Adhere to RFC166 formatting[/+] on Nov 15, 2023
  2. nyabinary commented on Nov 15, 2023

    @nyabinary
    Author
  3. kamadorueda commented on Nov 15, 2023

    @kamadorueda
    Owner

    It's probably a good question for the community once the RFC is adopted, the options are:

    1. make Alejandra follow the suggested style
    2. make Alejandra keep its existing style (there will always be an audience for this style)
    3. archive all alternative formatters so the community only has 1 option available
  4. nyabinary commented on Nov 15, 2023

    @nyabinary
    Author

    It's probably a good question for the community once the RFC is adopted, the options are:

    1. make Alejandra follow the suggested style
    
    2. make Alejandra keep its existing style (there will always be an audience for this style)
    
    3. archive all alternative formatters so the community only has 1 option available
    

    As I understand 3 is a non-goal, the formatter implementation is supposed to be considered more of a standard specification for formatting, so different implementations could exist as well, 1. Would be the most optimal.

  5. infinisil commented on Nov 15, 2023

    @infinisil

    The main intention behind making it a standard is to not make the implementation the standard. This allows some room for both bug fixes and minor improvements, but it also makes it clear which changes need to go though another RFC.

    And while Nixpkgs will have to use the official formatter, there's no problem with other standard-complient formatters existing. It would also be possible to change out the underlying implementation of the official formatter (as long as it's standards-compliant).

  6. infinisil commented on Nov 15, 2023

    @infinisil

    But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.

  7. nyabinary commented on Nov 15, 2023

    @nyabinary
    Author

    But I do think that for the benefit of everybody's time, it would be best to archive other formatters if the RFC is accepted and implemented.

    I disagree on this end, I think alejandra should adopt the standard, but some formatters, of course, can be archived like nixpkgs-fmt. Since that had one goal in mind, alejandra is more broad and widely used in the community (including myself) so I think its best to continue supporting it and change it to adhere to the RFC.

  8. piegamesde commented on Dec 4, 2023

    @piegamesde
    Contributor

    If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.

  9. nyabinary commented on Dec 19, 2023

    @nyabinary
    Author

    If adapting Alejandra to the RFC166 format was easy, I'd already have done so half a year ago. Initially, nixfmt was only our second choice after Alejandra.

    What's wrong with Alejandra that makes it harder to adher to RFC0166?

  10. changed the title [-]Adhere to RFC166 formatting[/-] [+]Adhere to RFC0166 formatting[/+] on Dec 19, 2023
  11. changed the title [-]Adhere to RFC0166 formatting[/-] [+]Adhere to [RFC 0166] formatting[/+] on Dec 19, 2023
  12. infinisil commented on Dec 20, 2023

    @infinisil

    We recorded some meetings notes about that here

  13. nyabinary commented on Feb 3, 2024

    @nyabinary
    Author

    Nix Formatter is now out for testing in nixpkgs.
    https://discourse.nixos.org/t/call-for-testing-nix-formatter/39179/

  14. nyabinary commented on Mar 19, 2024

    @nyabinary
    Author

    @kamadorueda
    The time is now to decide I guess, since NixOS/rfcs#166 got officially merged, and their now a tracking issue for nixfmt: NixOS/nixfmt#153

  15. justinrubek commented on Apr 16, 2024

    @justinrubek

    As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.

  16. nyabinary commented on Apr 16, 2024

    @nyabinary
    Author

    As much as I'd love for us all to fall on a single standard, after trying out the new nixfmt I don't think I'm willing to use an RFC166 compliant formatter on any of my projects. I'd prefer that alejandra remain as it is currently.

    We could have different modes tbf

  17. MattSturgeon commented on Apr 16, 2024

    @MattSturgeon

    We could have different modes tbf

    Is anyone actually going to work on and maintain that when there's already alternative formatting tools out there?

    It seems to me that alejandra has different goals to RFC 166. If so this should be considered a "won't fix".

  18. viperML commented on May 2, 2024

    @viperML

    After trying nixfmt-rfc-style, I have decided to keep using alejandra in my personal projects. My opinion is that it is ok to have different formatters to choose from, that don't comply with the "standard"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0