[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] update autogen for pod controllers to mention json6902 patch #629

Closed
zswanson opened this issue Sep 28, 2022 · 1 comment · Fixed by #643
Closed

[Enhancement] update autogen for pod controllers to mention json6902 patch #629

zswanson opened this issue Sep 28, 2022 · 1 comment · Fixed by #643
Labels
enhancement New feature or request
Milestone

Comments

@zswanson
Copy link
zswanson commented Sep 28, 2022

Description

The documentation for mutation policies with json6902 patches includes a small warning that these are not supported for autogen rules for Pods. However the autogen documentation page does not mention this, which led to some confusion as it seemed like it should be a supported use-case.

https://kyverno.io/docs/writing-policies/mutate/#rfc-6902-jsonpatch <--- notes the json6902 exclusion
https://kyverno.io/docs/writing-policies/autogen/ <--- does not note the json6902 exclusion

Recommend adding some similar warning text to docs/writing-policies/autogen/ that autogen is not enabled for patchesJson6902 mutation rules.

Additionally the text at https://kyverno.io/docs/writing-policies/mutate/#rfc-6902-jsonpatch has a somewhat confusing statement mutations using patchesJson6902 to Pods directly is not supported - since you can mutate pods directly with the json6902 patch, you just cannot get the autogen rules that also mutate pod templates in Controller resources.

Slack discussion

https://kubernetes.slack.com/archives/CLGR9BJU9/p1664282697092249

@zswanson zswanson added the enhancement New feature or request label Sep 28, 2022
@hitarth01
Copy link

Hey! I would like to work on this enhancement.

@chipzoller chipzoller added this to the 1.8.0 milestone Oct 6, 2022
@chipzoller chipzoller mentioned this issue Oct 11, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants