8000 modman filters with chars following a '*' aren't parsed properly in move_files() · Issue #10 · jreinke/modgit · GitHub
[go: up one dir, main page]

Skip to content

modman filters with chars following a '*' aren't parsed properly in move_files() #10

Open

Description

@jeffreyodum

If a module contains a modman file containing filters like "*{something}", files that match that filter are not deployed in move_files().

The problem happens when the modman file’s filter expression ends with “{something}”, like “app/etc/modules/.xml”.

Line 337 of modgit is:

line=”${line/*/}” # remove * char

Which means the comparison on line 339 of:

if [[ "$file" =~ ^$1 ]]

will fail in these cases as it will evaluate to something like:

if [[ "app/etc/local.xml.phpunit" =~ "app/etc/modules/.xml" ]]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0