YAML octal scalars not converted to ints #1251

matthew-eads · 2023-12-06T19:56:03Z

The 1.2.2 YAML spec indicates octal literals should be formatted as "0o123" which is annoyingly not consistent with what C++ thinks octal strings should look like (0123).
The stringstream extraction currently used expects octals to have a single leading '0', not '0o'. This is used by yaml-cpp:

yaml-cpp/include/yaml-cpp/node/convert.h

Lines 142 to 155 in eaf7205

    
           template <typename T> 
        
           typename std::enable_if<(std::is_same<T, unsigned char>::value || 
        
                                    std::is_same<T, signed char>::value), bool>::type 
        
           ConvertStreamTo(std::stringstream& stream, T& rhs) { 
        
             int num; 
        
             if ((stream >> std::noskipws >> num) && (stream >> std::ws).eof()) { 
        
               if (num >= (std::numeric_limits<T>::min)() && 
        
                   num <= (std::numeric_limits<T>::max)()) { 
        
                 rhs = static_cast<T>(num); 
        
                 return true; 
        
               } 
        
             } 
        
             return false; 
        
           }

Which ultimately means "0o123" cannot be converted to an int. "0123" on the other hand can be converted to an int, which is maybe not the desired behavior if strictly adhering to the 1.2 spec.
Note this is true only as of YAML 1.2, version 1.1 specifies octals the opposite way 🙃.
Somewhat related to treatment of booleans: #1198

jbeder · 2024-01-28T21:53:55Z

I think you're right. Probably the right behavior is to add the 0o123 format but not remove the 0123 format, since the YAML schema is allowed to be extended, and 0123 is reasonable to parse as octal.

akortunov · 2024-03-07T18:42:24Z

but not remove the 0123 format, since the YAML schema is allowed to be extended, and 0123 is reasonable to parse as octal.

According to 1.2 specs, an old format is supposed to be parsed as decimal numbers:

Octal values need a 0o prefix; e.g. 010 is now parsed with the value 10 rather than 8.

jwuttke · 2024-05-07T13:47:10Z

Only a minority of YAML users are talking C. The others are completely unprepared for 010 = 8. Upstream YAML was right to correct the specs.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YAML octal scalars not converted to ints #1251

YAML octal scalars not converted to ints #1251

YAML octal scalars not converted to ints #1251

YAML octal scalars not converted to ints #1251

Comments