8000 ansible_distribution_major_version · Issue #43 · inkatze/wildfly · GitHub
[go: up one dir, main page]

Skip to content

ansible_distribution_major_version #43

Open

Description

@okunc

Hello inkatze,

Firstly, thanks a lot for great role! I have updated from v3.0.0 to v4.0.1 and had hard times when role was skipping the opening of ports, because in tasks/configure.yml you are using:

  when: ansible_distribution_version|version_compare(7, '=') and wildfly_manage_firewall

.. but see my output of ansible all -m setup -a "filter=ansible_distribution*"

asdf | SUCCESS => {
    "ansible_facts": {
        "ansible_distribution": "RedHat", 
        "ansible_distribution_major_version": "7", 
        "ansible_distribution_release": "Maipo", 
        "ansible_distribution_version": "7.4"
    }, 
    "changed": false
}

.. so the conditional above didn't pass as 7!=7.4

I have updated tasks/configure.yml from ansible_distribution_version to ansible_distribution_major_version and it works like charm.

can you please include this? :]

thanks a lot for coop / update / wicked role and have a nice day!
okunc

Activity

  1. kostyrev commented on Oct 7, 2017

    @kostyrev
    Collaborator

    Why won't you just send a PR with those changes?

  2. okunc commented on Oct 19, 2017

    @okunc
    Author

    I will soon :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0