8000 Reconcile check-ledger 'Completed requires a Status' with output-hygiene REQ-E1.2 'leave untouched' output · Issue #137 · inkatze/planwright · GitHub
[go: up one dir, main page]

Skip to content

Reconcile check-ledger 'Completed requires a Status' with output-hygiene REQ-E1.2 'leave untouched' output #137

Open

Description

@inkatze

Context

Split out of PR #136 (output-hygiene Task 7, organic completion-annotation stamping). Copilot's review of #136 correctly surfaced a real cross-spec tension; the fix is a design decision that belongs outside that PR.

The tension

scripts/check-ledger.sh finalize_block() flags any block under ## Completed whose Status classifies as anything other than completed, and classify("") returns "none". So a Completed-section block with no - **Status:** line fails the guard (exit 1: "task N under Completed lacks a completion Status").

output-hygiene REQ-E1.2 / D-5 deliberately mandate three terminal outputs for the completion stamp: the canonical Completed · PR #<n> merged <date>, the degraded Completed · merged <date>, or leaving the annotation untouched when even the date is unknown — "never an invented PR number and never a third free-form variant."

The third output (leave untouched) is reachable for a completed task whose only evidence is a Planwright-Task: trailer with no remote merge date and no surviving branch (covered by test T7-C). In that narrow case the reconcile places the block in ## Completed with no Status line, which check-ledger.sh then flags.

The check-ledger rule predates Task 7 (Task 7 closes a previously "unowned" completion-annotation gap), so this is a pre-existing tension between two signed-off specs, not a regression introduced by #136.

Options to weigh

  1. Derive a trailer-commit date in scripts/orchestrate-state.sh so the degraded date-only stamp always fires → check-ledger always satisfied, but the leave untouched branch becomes unreachable for trailer completions → requires amending REQ-E1.2 / D-5 (reopens the "no third variant" decision the spec closed).
  2. Relax check-ledger to accept a statusless Completed block as valid (a snapshot that merely lags, per REQ-E1.1's derived-projection framing) → keeps REQ-E1.2 intact; changes the orchestration-concurrency guard's contract.
  3. Accept the residual as documented and narrow (the only case is trailer-only + no-remote + branch-gone).

Needs a design call on which contract wins; not urgent.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0