-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.gradle not found #234
Comments
I think this should fix it. infinitered/solidarity-react-native#30 This was my bad. Upgraded envinfo in solidarity but not its usage in this plugin. 🤦♂️ |
@tabrindle @kevinvangelder I'm still experiencing this issue with the following deps: "solidarity": "^2.3.1",
"solidarity-react-native": "^2.1.2" |
I'm also still getting this.
I've got my android sdk path setup in the Android section of my snapshot is reading as:
Solidarity is spitting out this error:
If I remove the Android section from the snapshot, everything passes, but that's obviously a less than ideal solution. |
Sorry for the delay on this. I'll be trying to take a look at this whenever I can. I don't think that the current code actually adheres to |
@GantMan sure, I can do that. Would you mind helping me get started by pointing to where the logic is, or a general idea on what needs to be done? |
Yup! So in All the code for checking is here: https://github.com/infinitered/solidarity-react-native/blob/master/extensions/react-native.js I hope this helps. Feel free to ask questions as you get started. |
As @tabrindle mentioned above you can change following lines of code in directory
add **await ** before getAndroidEnvData
2nd place to add in same file
like following
|
Thanks @kaushal9678. Should we merge this ? |
Will this be fixed? |
Would you like to send the PR? As long as it passes the tests, we can merge. |
Thanks, this fix works for me as well 👍🏼 |
Solidarity & solidarity-react-native are installed globally.
solidarity snapshot
worked fine, butsolidarity
returns:The text was updated successfully, but these errors were encountered: