Repository navigation
Expand file tree
/
Copy path.eslintrc.js
More file actions
141 lines (139 loc) · 4.28 KB
/
Copy path.eslintrc.js
File metadata and controls
141 lines (139 loc) · 4.28 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
const reactComponentTypeMessage = {
message:
'This type includes the children prop which is generally wrong, instead of using this type, type the props of the component',
};
module.exports = {
parser: '@typescript-eslint/parser',
env: {
browser: true,
es6: true,
node: true,
jest: true,
},
plugins: [
'react',
'react-hooks',
'jest',
'import',
'@typescript-eslint',
'@preconstruct/format-js-tag',
],
settings: {
react: {
version: 'detect',
},
},
rules: {
curly: ['error', 'multi-line'],
'jsx-quotes': 'error',
'no-trailing-spaces': 'error',
'no-undef': 'error',
'no-unused-expressions': 'error',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',
'@typescript-eslint/no-unused-vars': [
'error',
{
args: 'after-used',
ignoreRestSiblings: true,
vars: 'all',
},
],
'import/no-extraneous-dependencies': [
'error',
{
devDependencies: [
'**/__tests__/**/*',
'**/*test.*',
'**/tests/**/*',
'**/build/**/*',
`packages/fields/src/**/filterTests.*`,
'**/test-fixtures.*',
],
},
],
'import/no-unresolved': 'error',
'import/order': 'error',
'jest/valid-describe': 'off',
'jest/valid-expect': 'off',
'jest/no-conditional-expect': 'off',
'jest/no-standalone-expect': 'off',
'jest/expect-expect': 'off',
'jest/no-export': 'off',
'jest/valid-title': 'off',
'jest/no-try-expect': 'off',
'jest/no-disabled-tests': 'error',
'object-curly-spacing': ['error', 'always'],
quotes: ['error', 'single', { avoidEscape: true, allowTemplateLiterals: true }],
'react/jsx-boolean-value': 'warn',
'react/jsx-no-undef': 'error',
'react/jsx-uses-react': 'error',
'react/jsx-uses-vars': 'error',
'react/jsx-wrap-multilines': 'warn',
'react/no-did-mount-set-state': 'warn',
'react/no-did-update-set-state': 'warn',
'react/no-unknown-property': 'warn',
'react/react-in-jsx-scope': 'error',
'react/self-closing-comp': 'warn',
'react/sort-prop-types': 'warn',
semi: 'error',
strict: 'off',
'no-restricted-syntax': [
'error',
{
// Curious why we have this rule?
// - Enums only work for a subset of use cases that unions of string literals + objects work for and learning one language feature is easier than learning two language features
// - Enums are a new language feature which have runtime semantics which means they change TypeScript from JS + types to JS + types + extra language features which is harder to teach without clear advantages for this specific feature
selector: 'TSEnumDeclaration',
message: 'Use a union of string literals instead of an enum',
},
],
'@typescript-eslint/ban-types': [
'error',
{
extendDefaults: false,
types: {
Function:
'`Function` types are unsafe. Use more specific function types instead. e.g. (arg: number) => string',
String: {
message:
'The `String` type refers to the String object which is probably not what you want, you probably want `string` instead which refers to the string primitive type.',
fixWith: 'string',
},
ComponentType: reactComponentTypeMessage,
FC: reactComponentTypeMessage,
SFC: reactComponentTypeMessage,
'React.ComponentType': reactComponentTypeMessage,
'React.FC': reactComponentTypeMessage,
'React.SFC': reactComponentTypeMessage,
},
},
],
'@preconstruct/format-js-tag/format': 'error',
},
extends: ['plugin:jest/recommended'],
// Disable some rules for (code blocks within) Markdown docs
overrides: [
{
files: ['**/*.md'],
rules: {
'no-unused-vars': 'off',
'no-undef': 'off',
},
},
{
files: ['packages/fields/src/**/*.{js,ts,tsx}'],
rules: {
'import/no-commonjs': 'error',
},
},
{
files: ['**/*.{ts,tsx}'],
rules: {
// TypeScript already checks for the following things and they conflict with TypeScript
'import/no-unresolved': 'off',
'no-undef': 'off',
},
},
],
};