[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows - Add DisplayVersion key to registry #2905

Open
onwardmk opened this issue Jun 24, 2024 · 6 comments
Open

Windows - Add DisplayVersion key to registry #2905

onwardmk opened this issue Jun 24, 2024 · 6 comments
Labels
on-call reviewed

Comments

@onwardmk
Copy link
onwardmk commented Jun 24, 2024 •
edited
Loading

This project is for the Heroku CLI only and issues are reviewed as we are able. If you need more immediate assistance or help with anything not specific to the CLI itself, please use https://help.heroku.com.

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I'm on Windows, and I use WinGet to manage packages on my system. When I upgrade my packages with WinGet, I have to use the --include-unknown flag to upgrade this package because the DisplayVersion key hasn't been added to the registry per this comment. In addition, I have to upgrade this package every time instead of only when a new version's been published because the WinGet doesn't know the current version that's installed.

Without --include-unknown:
image

With `--include-unknown:
image

What is the expected behavior?

WinGet should only upgrade this package when the version's been bumped without using the --include-unknown option.
@zwhitfield3
Copy link
Contributor

Hi @onwardmk, we're sorry you're experiencing this issue. Unfortunately, there is nothing we can do here as we don't own or manage the winget-cli. I would recommend opening an issue with winget-cli about this problem.

@onwardmk
Copy link
Author

Hi @onwardmk, we're sorry you're experiencing this issue. Unfortunately, there is nothing we can do here as we don't own or manage the winget-cli. I would recommend opening an issue with winget-cli about this problem.

WinGet looks at a Windows registry setting on your application to know which version it's on; this setting is not unique to WinGet, it's on most Windows apps. I'm requesting that you add it to your application before publishing releases.

@onwardmk
Copy link
Author

@zwhitfield3 can you re-open this?

@onwardmk onwardmk mentioned this issue Jul 21, 2024
Closed
@sbosio
Copy link
Contributor
sbosio commented Aug 12, 2024

Hi @onwardmk,

Winget isn't currently a supported release channel for Heroku CLI. Windows installations should follow the instructions found in our Dev Center article.

The manifest files located at the Winget package manager repository have been created and contributed by external contributors unrelated with the Heroku CLI team and seem to be currently unmaintained.

I'm adding an internal ticket for our product owners to evaluate adding Winget to our automated release process.

@sbosio sbosio reopened this Aug 12, 2024
@sbosio
Copy link
Contributor
sbosio commented Aug 12, 2024

GUS Work Item for tracking purposes (Heroku internal).

@onwardmk
Copy link
Author

@sbosio, great, thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on-call reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbosio @zwhitfield3 @onwardmk