8000 D3475 — A resume that minvmd refuses shows minvmd's reason, and the error of bare min stays on screen · Issue #3477 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

D3475 — A resume that minvmd refuses shows minvmd's reason, and the error of bare min stays on screen #3477

Closed

Description

@norrietaylor

Task

Source: #3475

Plan block
### D3475 — A resume that minvmd refuses shows minvmd's reason, and the error of bare min stays on screen
  kind: task
  size: M
  est: 110 code, 150 tests
  executor: agent
  defect: bug
  layers:
    - client:
      - crates/minimal-client/src/attach.rs: resume_box_row_at returns minvmd's BoxControlReply::Error refusal as a typed error that carries its reason, in place of a warn line and Ok(false)
      - crates/minimal-client/src/box_registration.rs: resume_box_row fails the attach or exec with minvmd's refusal reason, for example the NO_ANSWERER text that names min finalize-install --show. Update the doc comment and add a test
      - crates/minimal/src/cmd/boxes/attach.rs: callers of resume_box_row print minvmd's refusal. interactive_attach keeps an attach error on screen after the terminal unwind
      - crates/minimal/src/cmd/boxes/vm_host.rs: add a fake VM host test where the resume is refused, and assert that the error carries minvmd's reason
      test: cargo nextest run -p minimal-client resume_refusal_carries_the_vm_host_reason
      test: cargo nextest run -p minimal resume_refused_by_vm_host_names_its_reason
    - daemon:
      - crates/minimald/src/connection.rs: send an exit status with each attach refusal, so ssh does not exit 255 and the blind unwind does not move the cursor over the error
      - crates/minimald/src/box_actor/attach.rs: AttachError::exit_code gives an exit status for BoxHostRowEnded and the other refusals. BoxHostRowEnded text stays for a row that minvmd released
      - crates/minimal/src/tests.rs: add a test: an attach that the daemon refuses leaves its error line on screen after the TerminalUnwind runs
      test: cargo nextest run -p minimald attach_refusal_sends_an_exit_status
      test: cargo nextest run -p minimal attach_error_stays_on_screen_after_the_unwind
  proof: With the DNS service stopped, bare min and min box attach on a stopped own_ip box both print minvmd's reason that names min finalize-install --show, and the error stays on screen.

Activity

  1. added
    bugSomething isn't working
    kind:taskA task the plan skill rendered; the body carries ## Task
    on Nov 16, 2026
  2. norrietaylor commented on Nov 16, 2026

    @norrietaylor
    MemberAuthor

    /implement

  3. minimal-foundry commented on Nov 16, 2026

    @minimal-foundry
    Contributor

    Round 6 of 10 changed nothing: every commit this round put on the branch above e49b92b is a merge of the base branch, so it carries no work of its own. #3482 is still open.

    branch agent/3477-a-resume-that-minvmd-refuses-shows-minvmd-s-reas · PR #3482

    round outcome job
    1 failed: OSError: [Errno 28] No space left on device 98a88723
    2 pushed e19fa6d4
    3 pushed 4f4436fa
    4 changed nothing: A person needs to take it from here. f4c5d95c
    5 changed nothing: every commit this round put on the branch above 6e1096f is a merge of the base branch, so it carries no work of its own 4c4a2ae9
    6 changed nothing: every commit this round put on the branch above e49b92b is a merge of the base branch, so it carries no work of its own 89b9f274

    Updated 2026-11-17T19:15:03.752Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingkind:taskA task the plan skill rendered; the body carries ## Task

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0