8000 minimal: resolve the selected loadouts once per activation, so BOX-183 checks what the box gets · Issue #3411 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

minimal: resolve the selected loadouts once per activation, so BOX-183 checks what the box gets #3411

Open

Description

@agent-137

Follow-up from Bryan's review of BOX T127 (#3311, PR #3388).

activate_box (crates/minimal/src/cmd/boxes/create.rs) reads the selected loadout files twice: once for the client expansion that runs the BOX-183 check (session_box_expansion), and once for the contribution it sends the daemon. A loadout file that changes between the two reads makes BOX-183 check different loadouts than the box gets.

Scope: resolve the selected loadouts once per activation, and pass the same resolved loadouts to the expansion and to the contribution. Pin it in a crates/minimal test where the loadout file changes between the two points, and the box gets exactly what BOX-183 checked.

Refs #2236, #3311, #3388.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0